Re: gpio-exar: Why filtering out Commtech devices?

From	Jan Kiszka <jan.kiszka@siemens.com>
Newsgroups	linux.kernel
Subject	Re: gpio-exar: Why filtering out Commtech devices?
Date	2017-05-22 20:20 +0200
Message-ID	<tK05X-Dl-5@gated-at.bofh.it> (permalink)
References	(1 earlier) <tJFkS-3Y0-5@gated-at.bofh.it> <tJOo9-1q6-11@gated-at.bofh.it> <tJOxQ-1ty-13@gated-at.bofh.it> <tJYnv-80c-23@gated-at.bofh.it> <tJYnv-80c-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2017-05-22 18:24, Jan Kiszka wrote:
> On 2017-05-22 17:17, Technical Support wrote:
>> Hello,
>>
>> The Exar MPIO pins are used by our device driver to control features of
>> the line driver and can't be used as GPIO pins.  I agree, the condition
>> can be moved to 8250_exar prior to a platform device being created for
>> the gpio_exar driver.
>>
> 
> Thanks a lot for the feedback! I will send a refactoring patch.

Hmm, are you possibly talking about PCI device with the IDs 0x2, 0x4,
0xa, 0xb (4222PCI335, 4224PCI335, 2324PCI335, 2328PCI335), because those
actually set the GPIOs for apparent internal reasons. However,
0x20..0x22 (4222PCIE, 4224PCIE, 4228PCIE) already share setup_gpio() via
pci_xr17v35x_setup(), and that looks different.

I'm also asking again because we just changed the default MPIO settings
for the latter to all inputs. If you depended on them to be all outputs
and 0, we may have broken something.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

Thread

gpio-exar: Why filtering out Commtech devices? Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-21 13:50 +0200
  Re: gpio-exar: Why filtering out Commtech devices? Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> - 2017-05-21 22:10 +0200
    Re: gpio-exar: Why filtering out Commtech devices? Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 07:50 +0200
      Re: gpio-exar: Why filtering out Commtech devices? Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 08:00 +0200
        Re: gpio-exar: Why filtering out Commtech devices? Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 18:30 +0200
          Re: gpio-exar: Why filtering out Commtech devices? Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 20:20 +0200
            Re: gpio-exar: Why filtering out Commtech devices? Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-23 17:10 +0200
              Re: gpio-exar: Why filtering out Commtech devices? Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-23 23:20 +0200

csiph-web