Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1646405

Re: gpio-exar: Why filtering out Commtech devices?

From Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Newsgroups linux.kernel
Subject Re: gpio-exar: Why filtering out Commtech devices?
Date 2017-05-21 22:10 +0200
Message-ID <tJFkS-3Y0-5@gated-at.bofh.it> (permalink)
References <tJxwZ-7g7-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Jan,

On 21/05/17 12:46, Jan Kiszka wrote:
> Hi Sudip,
>
> why do we carry
>
> 	if (pcidev->vendor != PCI_VENDOR_ID_EXAR)
> 		return -ENODEV;
>
> in gpio_exar_probe? This effectively prevents that
>
> 	EXAR_DEVICE(COMMTECH, COMMTECH_4222PCIE, pbn_exar_XR17V35x),
> 	EXAR_DEVICE(COMMTECH, COMMTECH_4224PCIE, pbn_exar_XR17V35x),
> 	EXAR_DEVICE(COMMTECH, COMMTECH_4228PCIE, pbn_exar_XR17V35x),
>
> gain GPIO support. Do those devices lack access to the pins? Or can we
> drop the filter. I don't have access to those devices, just wondering
> because the code is not explaining the reason.

Same here. I do not have these devices and have no idea if they support 
the gpio pins or not.

Adding Matt Schulte in the Cc list, maybe he can comment.


-- 
Regards
Sudip

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

gpio-exar: Why filtering out Commtech devices? Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-21 13:50 +0200
  Re: gpio-exar: Why filtering out Commtech devices? Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> - 2017-05-21 22:10 +0200
    Re: gpio-exar: Why filtering out Commtech devices? Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 07:50 +0200
      Re: gpio-exar: Why filtering out Commtech devices? Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 08:00 +0200
        Re: gpio-exar: Why filtering out Commtech devices? Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 18:30 +0200
          Re: gpio-exar: Why filtering out Commtech devices? Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-22 20:20 +0200
            Re: gpio-exar: Why filtering out Commtech devices? Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-23 17:10 +0200
              Re: gpio-exar: Why filtering out Commtech devices? Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-23 23:20 +0200

csiph-web