Re: [PATCH] kconfig: Check for libncurses before menuconfig

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] kconfig: Check for libncurses before menuconfig
Date	Sun, 21 May 2017 11:20:01 +0200
Message-ID	<tJvbP-5TR-1@gated-at.bofh.it> (permalink)
References	<tukLn-3bS-5@gated-at.bofh.it> <tJioh-5DU-1@gated-at.bofh.it> <tJjkm-6iU-7@gated-at.bofh.it>
X-Original-To	Borislav Petkov <bp@alien8.de>
Dkim-Filter	OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com v4L9Fseq027920
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1495358155; bh=PEFCXzjMl9DRekxa6jDBWloptldAWCCW1yd1oDWE7hQ=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=Y8v5xG3kHybTugE8LVBeyOgAnsXQwxUB1qnD1Aiumqps44DiPr28KVcijTVA0Fmuv uElfbnM0T8knZqgeq+HPBG5Fn5VI2Bu+/6v4bliGizH/1NoZ3x2VajKxsvtvag7gdW uXYWtLLIGDvfNt0212a9r8pjmMD+IymDflt4j8oXtPIY5LXEAsLcwVR9djQ7CqcByR xxOpSQmx/cbdxyG7yu+Q/3/7/cPv/FWcyG5x5pz4Ba64Bc1tOn2du9y2ACiKwPZ++K ULxT0bKFHovlcPaKTkSs5UCILR+V8/6/btqI0kcE37RgW34tVUIpjWJnAJHGtC+Voy TxhYyk/s2C3ZA==
X-Nifty-Srcip	[209.85.161.173]
X-Gm-Message-State	AODbwcBjXpYfTSpyW6UpUcu2oUujhOm0vw5jodYLkKLQPQO8KLVBMJtt giks/yjFufoVG6W3KEObGTak6zLsWw==
X-Received	by 10.129.84.195 with SMTP id i186mr14087653ywb.290.1495358154329; Sun, 21 May 2017 02:15:54 -0700 (PDT)
MIME-Version	1.0
X-Gmail-Original-Message-ID	<CAK7LNAT2tLPn70AcxnAZuv4=VAp2Wfg4ZRMEjVU0K2wntGSN9Q@mail.gmail.com>
Content-Type	text/plain; charset="UTF-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	50
Organization	linux.* mail to news gateway
X-Original-Cc	LKML <linux-kernel@vger.kernel.org>, Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
X-Original-Date	Sun, 21 May 2017 18:15:53 +0900
X-Original-Message-ID	<CAK7LNAT2tLPn70AcxnAZuv4=VAp2Wfg4ZRMEjVU0K2wntGSN9Q@mail.gmail.com>
X-Original-References	<20170409130708.4753-1-bp@alien8.de> <CAK7LNAT8tA=_Zi6i9w6cgHfkrwzxDm2-w2vuZpM57-P=YAvTUw@mail.gmail.com> <20170520203323.6ug3gq2yoms6acsu@pd.tnic>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1646296

Show key headers only | View raw

Hi Borislav,


2017-05-21 5:33 GMT+09:00 Borislav Petkov <bp@alien8.de>:
> On Sun, May 21, 2017 at 04:38:35AM +0900, Masahiro Yamada wrote:
>> Strange, I could not reproduce this.
>
> Remove libncurses5-dev or whatever it is called on your system and do:
>
> $ make menuconfig
>   HOSTCC  scripts/kconfig/mconf.o
> In file included from scripts/kconfig/mconf.c:23:0:
> scripts/kconfig/lxdialog/dialog.h:38:20: fatal error: curses.h: No such file or directory
>  #include CURSES_LOC
>                     ^
> compilation terminated.
> scripts/Makefile.host:124: recipe for target 'scripts/kconfig/mconf.o' failed
> make[1]: *** [scripts/kconfig/mconf.o] Error 1
> Makefile:548: recipe for target 'menuconfig' failed
> make: *** [menuconfig] Error 2


OK, I see.

So, it is $(obj)/mconf.o instead of $(obj)/mconf
that should depend on $(obj)/dochecklxdialog.


Could you change line 199

  $(addprefix $(obj)/,$(lxdialog)): $(obj)/dochecklxdialog

to

  $(addprefix $(obj)/, mconf.o $(lxdialog)): $(obj)/dochecklxdialog

and send v2, please?


This will make sure dochecklxdialog is run before compiling mconf.o
in parallel building.


Thanks!



-- 
Best Regards
Masahiro Yamada

Thread

Re: [PATCH] kconfig: Check for libncurses before menuconfig Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-05-20 21:40 +0200
  Re: [PATCH] kconfig: Check for libncurses before menuconfig Borislav Petkov <bp@alien8.de> - 2017-05-20 22:40 +0200
    Re: [PATCH] kconfig: Check for libncurses before menuconfig Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-05-21 11:20 +0200
      [PATCH v2] kconfig: Check for libncurses before menuconfig Borislav Petkov <bp@alien8.de> - 2017-05-21 11:50 +0200
        Re: [PATCH v2] kconfig: Check for libncurses before menuconfig Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-05-22 04:00 +0200

csiph-web