Re: [PATCH] kconfig: Check for libncurses before menuconfig

From	Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] kconfig: Check for libncurses before menuconfig
Date	2017-05-21 11:20 +0200
Message-ID	<tJvbP-5TR-1@gated-at.bofh.it> (permalink)
References	<tukLn-3bS-5@gated-at.bofh.it> <tJioh-5DU-1@gated-at.bofh.it> <tJjkm-6iU-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Borislav,


2017-05-21 5:33 GMT+09:00 Borislav Petkov <bp@alien8.de>:
> On Sun, May 21, 2017 at 04:38:35AM +0900, Masahiro Yamada wrote:
>> Strange, I could not reproduce this.
>
> Remove libncurses5-dev or whatever it is called on your system and do:
>
> $ make menuconfig
>   HOSTCC  scripts/kconfig/mconf.o
> In file included from scripts/kconfig/mconf.c:23:0:
> scripts/kconfig/lxdialog/dialog.h:38:20: fatal error: curses.h: No such file or directory
>  #include CURSES_LOC
>                     ^
> compilation terminated.
> scripts/Makefile.host:124: recipe for target 'scripts/kconfig/mconf.o' failed
> make[1]: *** [scripts/kconfig/mconf.o] Error 1
> Makefile:548: recipe for target 'menuconfig' failed
> make: *** [menuconfig] Error 2


OK, I see.

So, it is $(obj)/mconf.o instead of $(obj)/mconf
that should depend on $(obj)/dochecklxdialog.


Could you change line 199

  $(addprefix $(obj)/,$(lxdialog)): $(obj)/dochecklxdialog

to

  $(addprefix $(obj)/, mconf.o $(lxdialog)): $(obj)/dochecklxdialog

and send v2, please?


This will make sure dochecklxdialog is run before compiling mconf.o
in parallel building.


Thanks!



-- 
Best Regards
Masahiro Yamada

Thread

Re: [PATCH] kconfig: Check for libncurses before menuconfig Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-05-20 21:40 +0200
  Re: [PATCH] kconfig: Check for libncurses before menuconfig Borislav Petkov <bp@alien8.de> - 2017-05-20 22:40 +0200
    Re: [PATCH] kconfig: Check for libncurses before menuconfig Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-05-21 11:20 +0200
      [PATCH v2] kconfig: Check for libncurses before menuconfig Borislav Petkov <bp@alien8.de> - 2017-05-21 11:50 +0200
        Re: [PATCH v2] kconfig: Check for libncurses before menuconfig Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-05-22 04:00 +0200

csiph-web