Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1646271

Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures

Show all headers | View raw

On Wed, 17 May 2017 14:33:45 +0200,
Bhumika Goyal wrote:
> 
> On Wed, May 17, 2017 at 5:50 PM, Takashi Iwai <tiwai@suse.de> wrote:
> > On Wed, 17 May 2017 13:38:56 +0200,
> > Bhumika Goyal wrote:
> >>
> >> Declare snd_kcontrol_new structures as const as they are only passed an
> >> argument to the function snd_ctl_new1. This argument is of type const,
> >> so snd_kcontrol_new structures having this property can be made const.
> >> Done using Coccinelle:
> >>
> >> @r disable optional_qualifier@
> >> identifier x;
> >> position p;
> >> @@
> >> static struct snd_kcontrol_new x@p={...};
> >>
> >> @ok@
> >> identifier r.x;
> >> position p;
> >> @@
> >> snd_ctl_new1(&x@p,...)
> >>
> >> @bad@
> >> position p != {r.p,ok.p};
> >> identifier r.x;
> >> @@
> >> x@p
> >>
> >> @depends on !bad disable optional_qualifier@
> >> identifier r.x;
> >> @@
> >> +const
> >> struct snd_kcontrol_new x;
> >>
> >> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> >
> > As I already asked, could you send as a patchset if you have multiple
> > similar patches?
> >
> 
> Sure. Will combine the already sent ones and some new ones into a
> patchset and send again.

Well, since there haven't been new submissions and the patches are
trivial, I applied the existing four patches.  If you have newer ones,
please submit as a patchset.


thanks,

Takashi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures Bhumika Goyal <bhumirks@gmail.com> - 2017-05-17 13:40 +0200
  Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures Takashi Iwai <tiwai@suse.de> - 2017-05-17 14:30 +0200
    Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures Bhumika Goyal <bhumirks@gmail.com> - 2017-05-17 14:40 +0200
      Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures Takashi Iwai <tiwai@suse.de> - 2017-05-21 09:10 +0200
        Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures Bhumika Goyal <bhumirks@gmail.com> - 2017-05-22 08:00 +0200
          Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures Julia Lawall <julia.lawall@lip6.fr> - 2017-05-22 08:30 +0200
            Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures Takashi Iwai <tiwai@suse.de> - 2017-05-22 08:30 +0200
              Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures Bhumika Goyal <bhumirks@gmail.com> - 2017-05-22 08:40 +0200

csiph-web