Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures

From	Bhumika Goyal <bhumirks@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures
Date	2017-05-22 08:00 +0200
Message-ID	<tJOxP-1ty-1@gated-at.bofh.it> (permalink)
References	<tI5t7-2sV-13@gated-at.bofh.it> <tI6fw-32g-7@gated-at.bofh.it> <tI6pb-35o-1@gated-at.bofh.it> <tJta1-4G5-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, May 21, 2017 at 12:39 PM, Takashi Iwai <tiwai@suse.de> wrote:
> On Wed, 17 May 2017 14:33:45 +0200,
> Bhumika Goyal wrote:
>>
>> On Wed, May 17, 2017 at 5:50 PM, Takashi Iwai <tiwai@suse.de> wrote:
>> > On Wed, 17 May 2017 13:38:56 +0200,
>> > Bhumika Goyal wrote:
>> >>
>> >> Declare snd_kcontrol_new structures as const as they are only passed an
>> >> argument to the function snd_ctl_new1. This argument is of type const,
>> >> so snd_kcontrol_new structures having this property can be made const.
>> >> Done using Coccinelle:
>> >>
>> >> @r disable optional_qualifier@
>> >> identifier x;
>> >> position p;
>> >> @@
>> >> static struct snd_kcontrol_new x@p={...};
>> >>
>> >> @ok@
>> >> identifier r.x;
>> >> position p;
>> >> @@
>> >> snd_ctl_new1(&x@p,...)
>> >>
>> >> @bad@
>> >> position p != {r.p,ok.p};
>> >> identifier r.x;
>> >> @@
>> >> x@p
>> >>
>> >> @depends on !bad disable optional_qualifier@
>> >> identifier r.x;
>> >> @@
>> >> +const
>> >> struct snd_kcontrol_new x;
>> >>
>> >> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
>> >
>> > As I already asked, could you send as a patchset if you have multiple
>> > similar patches?
>> >
>>
>> Sure. Will combine the already sent ones and some new ones into a
>> patchset and send again.
>
> Well, since there haven't been new submissions and the patches are
> trivial, I applied the existing four patches.  If you have newer ones,
> please submit as a patchset.
>
>

Hey,

Thanks for applying the patches.
I have a doubt that since some of my coming patches are for the sound
subsystem containing similar changes and you will be applying those,
so can I combine and put all the changes in a single patch or sending
a patchset would be a correct way.

Thanks,
Bhumika

> thanks,
>
> Takashi

Thread

[PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures Bhumika Goyal <bhumirks@gmail.com> - 2017-05-17 13:40 +0200
  Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures Takashi Iwai <tiwai@suse.de> - 2017-05-17 14:30 +0200
    Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures Bhumika Goyal <bhumirks@gmail.com> - 2017-05-17 14:40 +0200
      Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures Takashi Iwai <tiwai@suse.de> - 2017-05-21 09:10 +0200
        Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures Bhumika Goyal <bhumirks@gmail.com> - 2017-05-22 08:00 +0200
          Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures Julia Lawall <julia.lawall@lip6.fr> - 2017-05-22 08:30 +0200
            Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures Takashi Iwai <tiwai@suse.de> - 2017-05-22 08:30 +0200
              Re: [PATCH] ALSA: sound/isa: constify snd_kcontrol_new structures Bhumika Goyal <bhumirks@gmail.com> - 2017-05-22 08:40 +0200

csiph-web