Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure

Path	csiph.com!news.redatomik.org!news.albasani.net!news.mixmin.net!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	Lukas Wunner <lukas@wunner.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure
Date	Sun, 21 May 2017 07:40:01 +0200
Message-ID	<tJrKV-3Ec-3@gated-at.bofh.it> (permalink)
References	<tIuKR-3YK-5@gated-at.bofh.it> <tIuUy-44c-23@gated-at.bofh.it> <tJqYx-2OK-5@gated-at.bofh.it> <tJrKV-3Ec-1@gated-at.bofh.it>
X-Original-To	"Levy, Amir (Jer)" <amir.jer.levy@intel.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.6.1 (2016-04-27)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	28
Organization	linux.* mail to news gateway
X-Original-Cc	Mika Westerberg <mika.westerberg@linux.intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Andreas Noever <andreas.noever@gmail.com>, "Jamet, Michael" <michael.jamet@intel.com>, "Bernat, Yehezkel" <yehezkel.bernat@intel.com>, Andy Lutomirski <luto@kernel.org>, "Mario.Limonciello@dell.com" <Mario.Limonciello@dell.com>, "Jared.Dominguez@dell.com" <Jared.Dominguez@dell.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date	Sun, 21 May 2017 07:35:21 +0200
X-Original-Message-ID	<20170521053521.GB3003@wunner.de>
X-Original-References	<20170518143914.60902-1-mika.westerberg@linux.intel.com> <20170518143914.60902-19-mika.westerberg@linux.intel.com> <20170521044735.GA2948@wunner.de> <E607265CB020454880711A6F96C05A030106862644@hasmsx107.ger.corp.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1646259

Show key headers only | View raw

On Sun, May 21, 2017 at 05:29:47AM +0000, Levy, Amir (Jer) wrote:
> On Sun, May 21 2017, 07:47 AM, Lukas Wunner wrote:
> > On Thu, May 18, 2017 at 05:39:08PM +0300, Mika Westerberg wrote:
> > > +
> > > +	default:
> > > +		sw->generation = 1;
> > > +		break;
> > 
> > If someone adds an entry for, say, a new TB3 controller to nhi_ids[] but
> > forgets to update this function, the controller is assigned the wrong
> > generation number.  It might be better to make TB3 the default and list
> > each TB1 controller instead since it's less likely for Intel to introduce
> > an older gen chip.
> > 
> > Generally I think it's problematic to require that multiple files are
> > touched whenever a new controller is added.  Isn't the generation number
> > or link speed (10/20/40) stored in some register in PCI config space
> > (VSEC 0x1234) or TB config space?
> 
> How about setting information, that isn't available from PCI, in
> pci_device_id.driver_data when initializing nhi_ids[]?

Right, that would also be possible, though reading the generation number
from a register would be more elegant, if such a register exists.

Thanks,

Lukas

Thread

[PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-18 16:50 +0200
  Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the  switch structure Lukas Wunner <lukas@wunner.de> - 2017-05-21 06:50 +0200
    RE: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the  switch structure "Levy, Amir (Jer)" <amir.jer.levy@intel.com> - 2017-05-21 07:40 +0200
      Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the  switch structure Lukas Wunner <lukas@wunner.de> - 2017-05-21 07:40 +0200
        Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the  switch structure Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-21 09:50 +0200
          Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the  switch structure Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-21 10:10 +0200
            RE: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the  switch structure "Levy, Amir (Jer)" <amir.jer.levy@intel.com> - 2017-05-21 10:10 +0200
              RE: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the  switch structure "Bernat, Yehezkel" <yehezkel.bernat@intel.com> - 2017-05-21 12:00 +0200
                Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the  switch structure Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-21 12:50 +0200
                RE: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the  switch structure "Bernat, Yehezkel" <yehezkel.bernat@intel.com> - 2017-05-21 13:20 +0200
                Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the  switch structure Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-21 13:50 +0200
              Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the  switch structure Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-21 12:50 +0200

csiph-web