Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1646258
| From | "Levy, Amir (Jer)" <amir.jer.levy@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | RE: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure |
| Date | 2017-05-21 07:40 +0200 |
| Message-ID | <tJrKV-3Ec-1@gated-at.bofh.it> (permalink) |
| References | <tIuKR-3YK-5@gated-at.bofh.it> <tIuUy-44c-23@gated-at.bofh.it> <tJqYx-2OK-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sun, May 21 2017, 07:47 AM, Lukas Wunner wrote: > On Thu, May 18, 2017 at 05:39:08PM +0300, Mika Westerberg wrote: > > + > > + default: > > + sw->generation = 1; > > + break; > > If someone adds an entry for, say, a new TB3 controller to nhi_ids[] but forgets > to update this function, the controller is assigned the wrong generation > number. It might be better to make TB3 the default and list each TB1 > controller instead since it's less likely for Intel to introduce an older gen chip. > > Generally I think it's problematic to require that multiple files are touched > whenever a new controller is added. Isn't the generation number or link speed > (10/20/40) stored in some register in PCI config space (VSEC 0x1234) or TB > config space? > > Thanks, > > Lukas > How about setting information, that isn't available from PCI, in pci_device_id.driver_data when initializing nhi_ids[]?
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-18 16:50 +0200
Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure Lukas Wunner <lukas@wunner.de> - 2017-05-21 06:50 +0200
RE: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure "Levy, Amir (Jer)" <amir.jer.levy@intel.com> - 2017-05-21 07:40 +0200
Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure Lukas Wunner <lukas@wunner.de> - 2017-05-21 07:40 +0200
Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-21 09:50 +0200
Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-21 10:10 +0200
RE: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure "Levy, Amir (Jer)" <amir.jer.levy@intel.com> - 2017-05-21 10:10 +0200
RE: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure "Bernat, Yehezkel" <yehezkel.bernat@intel.com> - 2017-05-21 12:00 +0200
Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-21 12:50 +0200
RE: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure "Bernat, Yehezkel" <yehezkel.bernat@intel.com> - 2017-05-21 13:20 +0200
Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-21 13:50 +0200
Re: [PATCH 18/24] thunderbolt: Store Thunderbolt generation in the switch structure Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-05-21 12:50 +0200
csiph-web