Re: [PATCH] lpfc: nvmet_fc: fix format string

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] lpfc: nvmet_fc: fix format string
Date	2017-05-21 02:50 +0200
Message-ID	<tJneh-kw-1@gated-at.bofh.it> (permalink)
References	<tIL8Z-7Kt-7@gated-at.bofh.it> <tJ9O1-51-9@gated-at.bofh.it> <tJi4V-5vp-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, 2017-05-20 at 21:10 +0200, Arnd Bergmann wrote:
> On Sat, May 20, 2017 at 12:28 PM, Joe Perches <joe@perches.com> wrote:
> > On Fri, 2017-05-19 at 10:04 +0200, Arnd Bergmann wrote:
> > > The lpfc_nvmeio_data() tracing helper always takes a format string and
> > > three additional arguments.
> > 
> > No it doesn't.  It takes a format and arguments.
> > 
> > I don't disagree with the patch, just the characterization
> > of the lpfc_mvmeio_data call in the commit message.
> 
> I think my description is correct, it's just not obvious from
> reading the code until you also look at the lpfc_debugfs_nvme_trc
> prototype:

OK, but more that's a mismatch between a function and its
arguments and a different called function within it.

Thread

[PATCH] lpfc: nvmet_fc: fix format string Arnd Bergmann <arnd@arndb.de> - 2017-05-19 10:10 +0200
  Re: [PATCH] lpfc: nvmet_fc: fix format string Joe Perches <joe@perches.com> - 2017-05-20 12:30 +0200
    Re: [PATCH] lpfc: nvmet_fc: fix format string Arnd Bergmann <arnd@arndb.de> - 2017-05-20 21:20 +0200
      Re: [PATCH] lpfc: nvmet_fc: fix format string Joe Perches <joe@perches.com> - 2017-05-21 02:50 +0200
  Re: [PATCH] lpfc: nvmet_fc: fix format string "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-05-24 04:50 +0200

csiph-web