Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1646093

Re: [PATCH] lpfc: nvmet_fc: fix format string

Show all headers | View raw

On Fri, 2017-05-19 at 10:04 +0200, Arnd Bergmann wrote:
> The lpfc_nvmeio_data() tracing helper always takes a format string and
> three additional arguments.

No it doesn't.  It takes a format and arguments.

I don't disagree with the patch, just the characterization
of the lpfc_mvmeio_data call in the commit message.

> The latest caller has a format string with
> only two integer arguments, causing this harmless warning:
> 
> drivers/scsi/lpfc/lpfc_nvmet.c: In function 'lpfc_nvmet_xmt_fcp_release':
> drivers/scsi/lpfc/lpfc_nvmet.c:802:25: error: too many arguments for format [-Werror=format-extra-args]
>   lpfc_nvmeio_data(phba, "NVMET FCP FREE: xri x%x ste %d\n", ctxp->oxid,
> 
> We could add a dummy argument here, but it seems reasonable to print
> the 'abort' flag as the third argument.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] lpfc: nvmet_fc: fix format string Arnd Bergmann <arnd@arndb.de> - 2017-05-19 10:10 +0200
  Re: [PATCH] lpfc: nvmet_fc: fix format string Joe Perches <joe@perches.com> - 2017-05-20 12:30 +0200
    Re: [PATCH] lpfc: nvmet_fc: fix format string Arnd Bergmann <arnd@arndb.de> - 2017-05-20 21:20 +0200
      Re: [PATCH] lpfc: nvmet_fc: fix format string Joe Perches <joe@perches.com> - 2017-05-21 02:50 +0200
  Re: [PATCH] lpfc: nvmet_fc: fix format string "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-05-24 04:50 +0200

csiph-web