[PATCH -next] drm/vgem: Fix return value check in vgem_init()

From	Wei Yongjun <weiyj.lk@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH -next] drm/vgem: Fix return value check in vgem_init()
Date	2017-05-21 03:30 +0200
Message-ID	<tJnQZ-OO-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Wei Yongjun <weiyongjun1@huawei.com>

In case of error, the function platform_device_register_simple() returns
ERR_PTR() and never returns NULL. The NULL test in the return value
check should be replaced with IS_ERR().

Fixes: 315f0242aa2b ("drm/vgem: Convert to a struct drm_device subclass")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/gpu/drm/vgem/vgem_drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
index 54ec94c..18f401b 100644
--- a/drivers/gpu/drm/vgem/vgem_drv.c
+++ b/drivers/gpu/drm/vgem/vgem_drv.c
@@ -438,8 +438,8 @@ static int __init vgem_init(void)
 
 	vgem_device->platform =
 		platform_device_register_simple("vgem", -1, NULL, 0);
-	if (!vgem_device->platform) {
-		ret = -ENODEV;
+	if (IS_ERR(vgem_device->platform)) {
+		ret = PTR_ERR(vgem_device->platform);
 		goto out_fini;
 	}

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] drm/vgem: Fix return value check in vgem_init() Wei Yongjun <weiyj.lk@gmail.com> - 2017-05-21 03:30 +0200
  Re: [PATCH -next] drm/vgem: Fix return value check in vgem_init() Chris Wilson <chris@chris-wilson.co.uk> - 2017-05-21 14:10 +0200
    Re: [PATCH -next] drm/vgem: Fix return value check in vgem_init() Daniel Vetter <daniel@ffwll.ch> - 2017-05-22 09:50 +0200

csiph-web