Re: [PATCH -next] drm/vgem: Fix return value check in vgem_init()

From	Daniel Vetter <daniel@ffwll.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH -next] drm/vgem: Fix return value check in vgem_init()
Date	2017-05-22 09:50 +0200
Message-ID	<tJQgi-2Cc-15@gated-at.bofh.it> (permalink)
References	<tJnQZ-OO-1@gated-at.bofh.it> <tJxQm-7Cj-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, May 21, 2017 at 01:09:05PM +0100, Chris Wilson wrote:
> On Sun, May 21, 2017 at 01:19:39AM +0000, Wei Yongjun wrote:
> > From: Wei Yongjun <weiyongjun1@huawei.com>
> > 
> > In case of error, the function platform_device_register_simple() returns
> > ERR_PTR() and never returns NULL. The NULL test in the return value
> > check should be replaced with IS_ERR().
> > 
> > Fixes: 315f0242aa2b ("drm/vgem: Convert to a struct drm_device subclass")
> 
> This is wrong, the bug was introduced in
> af33a9190d02 ("drm/vgem: Enable dmabuf import interfaces")
> not that it matters since it is the same tag.

Fixed.

> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Checked it is an ERR_PTR return on failure, so
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Applied, thanks for patch&review.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH -next] drm/vgem: Fix return value check in vgem_init() Wei Yongjun <weiyj.lk@gmail.com> - 2017-05-21 03:30 +0200
  Re: [PATCH -next] drm/vgem: Fix return value check in vgem_init() Chris Wilson <chris@chris-wilson.co.uk> - 2017-05-21 14:10 +0200
    Re: [PATCH -next] drm/vgem: Fix return value check in vgem_init() Daniel Vetter <daniel@ffwll.ch> - 2017-05-22 09:50 +0200

csiph-web