Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1646138

[PATCH 1/2] vhost/scsi: Improve a size determination in four functions

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 20 May 2017 13:48:44 +0200

Replace the specification of four data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/vhost/scsi.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
index fd6c8b66f06f..650533916c19 100644
--- a/drivers/vhost/scsi.c
+++ b/drivers/vhost/scsi.c
@@ -597,8 +597,7 @@ vhost_scsi_get_tag(struct vhost_virtqueue *vq, struct vhost_scsi_tpg *tpg,
 	sg = cmd->tvc_sgl;
 	prot_sg = cmd->tvc_prot_sgl;
 	pages = cmd->tvc_upages;
-	memset(cmd, 0, sizeof(struct vhost_scsi_cmd));
-
+	memset(cmd, 0, sizeof(*cmd));
 	cmd->tvc_sgl = sg;
 	cmd->tvc_prot_sgl = prot_sg;
 	cmd->tvc_upages = pages;
@@ -1757,5 +1756,5 @@ static int vhost_scsi_make_nexus(struct vhost_scsi_tpg *tpg,
 		return -EEXIST;
 	}
 
-	tv_nexus = kzalloc(sizeof(struct vhost_scsi_nexus), GFP_KERNEL);
+	tv_nexus = kzalloc(sizeof(*tv_nexus), GFP_KERNEL);
 	if (!tv_nexus) {
@@ -1958,5 +1957,5 @@ vhost_scsi_make_tpg(struct se_wwn *wwn,
 	if (kstrtou16(name + 5, 10, &tpgt) || tpgt >= VHOST_SCSI_MAX_TARGET)
 		return ERR_PTR(-EINVAL);
 
-	tpg = kzalloc(sizeof(struct vhost_scsi_tpg), GFP_KERNEL);
+	tpg = kzalloc(sizeof(*tpg), GFP_KERNEL);
 	if (!tpg) {
@@ -2012,5 +2011,5 @@ vhost_scsi_make_tport(struct target_fabric_configfs *tf,
 	/* if (vhost_scsi_parse_wwn(name, &wwpn, 1) < 0)
 		return ERR_PTR(-EINVAL); */
 
-	tport = kzalloc(sizeof(struct vhost_scsi_tport), GFP_KERNEL);
+	tport = kzalloc(sizeof(*tport), GFP_KERNEL);
 	if (!tport) {
-- 
2.13.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] vhost/scsi: Adjustments for five function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-20 16:40 +0200
  [PATCH 2/2] vhost/scsi: Delete error messages for failed memory  allocations in five functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-20 16:40 +0200
    Re: [PATCH 2/2] vhost/scsi: Delete error messages for failed memory  allocations in five functions Stefan Hajnoczi <stefanha@gmail.com> - 2017-05-22 11:50 +0200
      Re: [PATCH 2/2] vhost/scsi: Delete error messages for failed memory  allocations in five functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-22 13:00 +0200
        Re: [PATCH 2/2] vhost/scsi: Delete error messages for failed memory  allocations in five functions Stefan Hajnoczi <stefanha@gmail.com> - 2017-05-22 13:30 +0200
          Re: vhost/scsi: Delete error messages for failed memory allocations  in five functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-22 13:40 +0200
            Re: vhost/scsi: Delete error messages for failed memory allocations  in five functions Stefan Hajnoczi <stefanha@gmail.com> - 2017-05-22 16:20 +0200
              Re: vhost/scsi: Delete error messages for failed memory allocations  in five functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-22 16:30 +0200
          Re: [PATCH 2/2] vhost/scsi: Delete error messages for failed memory  allocations in five functions Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-22 14:40 +0200
            Re: [PATCH 2/2] vhost/scsi: Delete error messages for failed memory  allocations in five functions Stefan Hajnoczi <stefanha@gmail.com> - 2017-05-22 16:10 +0200
  [PATCH 1/2] vhost/scsi: Improve a size determination in four  functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-20 16:40 +0200
    Re: [PATCH 1/2] vhost/scsi: Improve a size determination in four  functions Stefan Hajnoczi <stefanha@gmail.com> - 2017-05-22 11:40 +0200

csiph-web