Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1646682

Re: [PATCH 2/2] vhost/scsi: Delete error messages for failed memory allocations in five functions

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sat, May 20, 2017 at 04:32:17PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 20 May 2017 15:50:30 +0200
> 
> Omit seven extra messages for memory allocation failures in these functions.
> 
> This issue was detected by using the Coccinelle software.
> 
> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf

Please include an actual explanation for this change instead of linking
to slides.  Why are you trying to get rid of memory allocation failure
messages?

> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/vhost/scsi.c | 24 +++++++-----------------
>  1 file changed, 7 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
> index 650533916c19..49d07950e2e5 100644
> --- a/drivers/vhost/scsi.c
> +++ b/drivers/vhost/scsi.c
> @@ -417,5 +417,4 @@ vhost_scsi_allocate_evt(struct vhost_scsi *vs,
>  	if (!evt) {
> -		vq_err(vq, "Failed to allocate vhost_scsi_evt\n");

#define vq_err(vq, fmt, ...) do {                                  \
                pr_debug(pr_fmt(fmt), ##__VA_ARGS__);       \
                if ((vq)->error_ctx)                               \
                                eventfd_signal((vq)->error_ctx, 1);\
        } while (0)

You silently dropped the eventfd_signal() call.  Please explain.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] vhost/scsi: Adjustments for five function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-20 16:40 +0200
  [PATCH 2/2] vhost/scsi: Delete error messages for failed memory  allocations in five functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-20 16:40 +0200
    Re: [PATCH 2/2] vhost/scsi: Delete error messages for failed memory  allocations in five functions Stefan Hajnoczi <stefanha@gmail.com> - 2017-05-22 11:50 +0200
      Re: [PATCH 2/2] vhost/scsi: Delete error messages for failed memory  allocations in five functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-22 13:00 +0200
        Re: [PATCH 2/2] vhost/scsi: Delete error messages for failed memory  allocations in five functions Stefan Hajnoczi <stefanha@gmail.com> - 2017-05-22 13:30 +0200
          Re: vhost/scsi: Delete error messages for failed memory allocations  in five functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-22 13:40 +0200
            Re: vhost/scsi: Delete error messages for failed memory allocations  in five functions Stefan Hajnoczi <stefanha@gmail.com> - 2017-05-22 16:20 +0200
              Re: vhost/scsi: Delete error messages for failed memory allocations  in five functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-22 16:30 +0200
          Re: [PATCH 2/2] vhost/scsi: Delete error messages for failed memory  allocations in five functions Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-22 14:40 +0200
            Re: [PATCH 2/2] vhost/scsi: Delete error messages for failed memory  allocations in five functions Stefan Hajnoczi <stefanha@gmail.com> - 2017-05-22 16:10 +0200
  [PATCH 1/2] vhost/scsi: Improve a size determination in four  functions SF Markus Elfring <elfring@users.sourceforge.net> - 2017-05-20 16:40 +0200
    Re: [PATCH 1/2] vhost/scsi: Improve a size determination in four  functions Stefan Hajnoczi <stefanha@gmail.com> - 2017-05-22 11:40 +0200

csiph-web