Re: [PATCH v4 5/6] spi: slave: Add SPI slave handler reporting uptime at previous message

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 5/6] spi: slave: Add SPI slave handler reporting uptime at previous message
Date	2017-05-22 12:20 +0200
Message-ID	<tJSBs-4qg-5@gated-at.bofh.it> (permalink)
References	<tI6yR-392-5@gated-at.bofh.it> <tI6yS-392-7@gated-at.bofh.it> <tIw9Y-54I-13@gated-at.bofh.it> <tJSBs-4qg-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, May 22, 2017 at 1:13 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Thu, May 18, 2017 at 6:01 PM, Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
>> On Wed, May 17, 2017 at 3:47 PM, Geert Uytterhoeven
>> <geert+renesas@glider.be> wrote:

>>> +       rem_ns = do_div(ts, 1000000000) / 1000;
>>
>> You divide ts by 10^9, which makes it seconds if it was nanoseconds.
>> But reminder is still in nanoseconds and you divide it by 10^3.
>
>> If I didn't miss anything it should be called like
>> rem_ns -> reminder_ms
>
> Thanks, that must be a remainder from before I reworked the calculation.
> Will change it to rem_us (it's in microseconds, not milliseconds).

Yeah, correct, thanks.

-- 
With Best Regards,
Andy Shevchenko

Thread

[PATCH v4 5/6] spi: slave: Add SPI slave handler reporting uptime at previous message Geert Uytterhoeven <geert+renesas@glider.be> - 2017-05-17 14:50 +0200
  Re: [PATCH v4 5/6] spi: slave: Add SPI slave handler reporting uptime  at previous message Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-18 18:10 +0200
    Re: [PATCH v4 5/6] spi: slave: Add SPI slave handler reporting uptime  at previous message Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-22 12:20 +0200
    Re: [PATCH v4 5/6] spi: slave: Add SPI slave handler reporting uptime  at previous message Geert Uytterhoeven <geert@linux-m68k.org> - 2017-05-22 12:20 +0200

csiph-web