Re: [RFC PATCH v2 09/17] cgroup: Keep accurate count of tasks in each css_set

From	Waiman Long <longman@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH v2 09/17] cgroup: Keep accurate count of tasks in each css_set
Date	2017-05-18 18:00 +0200
Message-ID	<tIw0h-4M2-5@gated-at.bofh.it> (permalink)
References	<tHoo9-lZ-3@gated-at.bofh.it> <tHooa-lZ-37@gated-at.bofh.it> <tIeZs-8x-21@gated-at.bofh.it>
Organization	Red Hat

Show all headers | View raw

On 05/17/2017 05:40 PM, Tejun Heo wrote:
> Hello,
>
> On Mon, May 15, 2017 at 09:34:08AM -0400, Waiman Long wrote:
>> The reference count in the css_set data structure was used as a
>> proxy of the number of tasks attached to that css_set. However, that
>> count is actually not an accurate measure especially with thread mode
>> support. So a new variable task_count is added to the css_set to keep
>> track of the actual task count. This new variable is protected by
>> the css_set_lock. Functions that require the actual task count are
>> updated to use the new variable.
>>
>> Signed-off-by: Waiman Long <longman@redhat.com>
> Looks good.  We probably should replace css_set_populated() to use
> this too.
>
> Thanks.
>
Yes, you are right. css_set_populated() can be replaced with a check on
the task_count.

Regards,
Longman

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH v2 09/17] cgroup: Keep accurate count of tasks in each css_set Waiman Long <longman@redhat.com> - 2017-05-15 15:40 +0200
  Re: [RFC PATCH v2 09/17] cgroup: Keep accurate count of tasks in  each css_set Tejun Heo <tj@kernel.org> - 2017-05-17 23:50 +0200
    Re: [RFC PATCH v2 09/17] cgroup: Keep accurate count of tasks in each  css_set Waiman Long <longman@redhat.com> - 2017-05-18 18:00 +0200

csiph-web