Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1643655

Re: [RFC PATCH v2 09/17] cgroup: Keep accurate count of tasks in each css_set

Show all headers | View raw

Hello,

On Mon, May 15, 2017 at 09:34:08AM -0400, Waiman Long wrote:
> The reference count in the css_set data structure was used as a
> proxy of the number of tasks attached to that css_set. However, that
> count is actually not an accurate measure especially with thread mode
> support. So a new variable task_count is added to the css_set to keep
> track of the actual task count. This new variable is protected by
> the css_set_lock. Functions that require the actual task count are
> updated to use the new variable.
> 
> Signed-off-by: Waiman Long <longman@redhat.com>

Looks good.  We probably should replace css_set_populated() to use
this too.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH v2 09/17] cgroup: Keep accurate count of tasks in each css_set Waiman Long <longman@redhat.com> - 2017-05-15 15:40 +0200
  Re: [RFC PATCH v2 09/17] cgroup: Keep accurate count of tasks in  each css_set Tejun Heo <tj@kernel.org> - 2017-05-17 23:50 +0200
    Re: [RFC PATCH v2 09/17] cgroup: Keep accurate count of tasks in each  css_set Waiman Long <longman@redhat.com> - 2017-05-18 18:00 +0200

csiph-web