Re: [PATCH net-next 3/6] net: bridge: break if __br_mdb_del fails

From	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 3/6] net: bridge: break if __br_mdb_del fails
Date	2017-05-18 17:50 +0200
Message-ID	<tIvQB-4Ia-5@gated-at.bofh.it> (permalink)
References	<tIePL-8wt-5@gated-at.bofh.it> <tIePL-8wt-9@gated-at.bofh.it> <tItYu-3le-5@gated-at.bofh.it> <tIvnz-4vr-11@gated-at.bofh.it> <tIvxh-4z7-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Nikolay,

Nikolay Aleksandrov <nikolay@cumulusnetworks.com> writes:

>> OK good to know. That intention wasn't obvious. I can make __br_mdb_del
>> return void instead? What about the rest of the patchset if I do so?
>
> If you make it return void we will not be able to return proper error value
> when doing a single operation (the else case). About the rest I see only some
> minor style issues, I'll comment on the respective patches. Another minor nit is 
> using switch() instead of if/else for the message types but that is really up to 
> you, I don't mind either way. :-)

Ho OK I understand better the batch vs single delete operation now.
__br_mdb_do hardly makes sense now, because we don't know which case we
are handling... But factorizing br_mdb_do still makes sense. I'll come
up with something.

Thanks,

        Vivien

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next 3/6] net: bridge: break if __br_mdb_del fails Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-17 23:40 +0200
  Re: [PATCH net-next 3/6] net: bridge: break if __br_mdb_del fails Nikolay Aleksandrov <nikolay@cumulusnetworks.com> - 2017-05-18 15:50 +0200
    Re: [PATCH net-next 3/6] net: bridge: break if __br_mdb_del    fails Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-18 17:20 +0200
      Re: [PATCH net-next 3/6] net: bridge: break if __br_mdb_del fails Nikolay Aleksandrov <nikolay@cumulusnetworks.com> - 2017-05-18 17:30 +0200
        Re: [PATCH net-next 3/6] net: bridge: break if __br_mdb_del    fails Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-18 17:50 +0200

csiph-web