Re: [PATCH net-next 3/6] net: bridge: break if __br_mdb_del fails

From	Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 3/6] net: bridge: break if __br_mdb_del fails
Date	2017-05-18 15:50 +0200
Message-ID	<tItYu-3le-5@gated-at.bofh.it> (permalink)
References	<tIePL-8wt-5@gated-at.bofh.it> <tIePL-8wt-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 5/18/17 12:27 AM, Vivien Didelot wrote:
> Be symmetric with br_mdb_add and break if __br_mdb_del returns an error.
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> ---
>   net/bridge/br_mdb.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c
> index d20a01622b20..24eeeefb4179 100644
> --- a/net/bridge/br_mdb.c
> +++ b/net/bridge/br_mdb.c
> @@ -688,8 +688,9 @@ static int br_mdb_del(struct sk_buff *skb, struct nlmsghdr *nlh,
>   		list_for_each_entry(v, &vg->vlan_list, vlist) {
>   			entry->vid = v->vid;
>   			err = __br_mdb_del(br, entry);
> -			if (!err)
> -				__br_mdb_notify(dev, p, entry, RTM_DELMDB);
> +			if (err)
> +				break;
> +			__br_mdb_notify(dev, p, entry, RTM_DELMDB);
>   		}
>   	} else {
>   		err = __br_mdb_del(br, entry);
> 

This can potentially break user-space scripts that rely on the best-effort
behaviour, this is the normal "delete without vid & enabled vlan filtering".
You can check the fdb delete code which does the same, this was intentional.

You can add an mdb entry without a vid to all vlans, add a vlan and then try
to remove it from all vlans where it is present - with this patch obviously
that will fail at the new vlan.

Thread

[PATCH net-next 3/6] net: bridge: break if __br_mdb_del fails Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-17 23:40 +0200
  Re: [PATCH net-next 3/6] net: bridge: break if __br_mdb_del fails Nikolay Aleksandrov <nikolay@cumulusnetworks.com> - 2017-05-18 15:50 +0200
    Re: [PATCH net-next 3/6] net: bridge: break if __br_mdb_del    fails Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-18 17:20 +0200
      Re: [PATCH net-next 3/6] net: bridge: break if __br_mdb_del fails Nikolay Aleksandrov <nikolay@cumulusnetworks.com> - 2017-05-18 17:30 +0200
        Re: [PATCH net-next 3/6] net: bridge: break if __br_mdb_del    fails Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-05-18 17:50 +0200

csiph-web