[PATCH v2 0/2] serdev: fix broken lifetime assumptions

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Johan Hovold <johan@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH v2 0/2] serdev: fix broken lifetime assumptions
Date	Thu, 18 May 2017 17:40:02 +0200
Message-ID	<tIvGV-4Cy-5@gated-at.bofh.it> (permalink)
X-Original-To	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=Ccc9qmuzumpeHpH2aGR/yNIOo26ZCckoucomw1DGm5Q=; b=cKwVw1vx9OfoES+Z+8Aw0ReLvmo17+oaEkfeXsph9qDxOj//0kbNmbvJ8d0aud5eWn HOLFNJ5b7ZT+iZUephhpHWtxuFaOcuqWTxbHTXASeE0NGYyEf0bL7W9+Y6oITM6c4E1M Crvpyozz39AJBk5QMHwl+gHmi3NnqQibfsk8KAU94vQVb4n4IWPfa+oV/h9M8bqC2Ptf RxsME5UraMZGzfB84LSAzKCYDDbiI4HwHQ9IgJRDfZ2fmMHwGK/UwFdq9U/t3CMDE5GN d8qkIlC17gQSUUTNPc11ob7ykB7G5zqqa0KsqfNXSs3JpGW9sxdkxLvkR2NygGnrZJJv OKBA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=Ccc9qmuzumpeHpH2aGR/yNIOo26ZCckoucomw1DGm5Q=; b=fr7H9wLspcImzkrmPbpZwbjHJ4U+c0S6o1TnF+UZl44ius453VCIerhIDtrB2baQyJ AroOkL0rRGXRjXoZ0IJFQhnx8hR0YLYddvSGc0S3H6xaHvIklgkW+SptEt27AF1z3Fws FHmMDI9QlRhN4qJl1Rb1HDtrhrl26mw/77ge942cdul43ZwzinNyitOyOCxxUZjqyfNI G/MizU4aulL2FBRJBkhEj9Tty0kl/p9ZkBRlnt8FfFqa7R4H2shlMC765rXnMzwevjx5 oi4OsroFFai4JZUFM2xYoyyQb6hTuBjv/cSU3XapQedoJbmwnyJH0XM2bNB/6kn9kKzU KQFg==
X-Gm-Message-State	AODbwcCpPuDSjG8aIDETXV1XdrRlprQmTH940oxrzAaRtOlXzvFTnuyd DdyEvtfY9EDrvg==
X-Received	by 10.46.9.208 with SMTP id 199mr1317724ljj.23.1495121601048; Thu, 18 May 2017 08:33:21 -0700 (PDT)
X-Mailer	git-send-email 2.13.0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	37
Organization	linux.* mail to news gateway
X-Original-Cc	Rob Herring <robh@kernel.org>, Jiri Slaby <jslaby@suse.com>, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold <johan@kernel.org>
X-Original-Date	Thu, 18 May 2017 17:32:59 +0200
X-Original-Message-ID	<20170518153301.28885-1-johan@kernel.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1644695

Show key headers only | View raw

This series fixes a number of issues with the new serdev code, which was
based on incorrect tty-port lifetime assumptions.

The first patch in v1 of this series disables serdev support by reverting the
patch which hooked into the tty layer in a broken way that leads to crashes and
leaks when deregistering devices. That one has now been applied to tty-linus
with a stable tag (for v4.11).

The remaining two patches again re-enables serdev (first enabled in 4.11, but
soon reverted in stable) for a subset of tty drivers by adding adding a new
interface for registering serdev devices and using that in serial core only.

More details can be found in the individual commit messages.

Johan


Changes in v2
 - rebase on tty-linus
 - drop first two patches that have already been applied
 - remove a stray newline in patch 1/2
 - add Rob's reviewed-by tag


Johan Hovold (2):
  tty/serdev: add serdev registration interface
  serial: enable serdev support

 drivers/tty/serdev/serdev-ttyport.c |  6 ++-
 drivers/tty/serial/serial_core.c    |  4 +-
 drivers/tty/tty_port.c              | 75 +++++++++++++++++++++++++++++++++++++
 include/linux/serdev.h              |  7 +++-
 include/linux/tty.h                 |  9 +++++
 5 files changed, 95 insertions(+), 6 deletions(-)

-- 
2.13.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v2 0/2] serdev: fix broken lifetime assumptions Johan Hovold <johan@kernel.org> - 2017-05-18 17:40 +0200

csiph-web