Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1643986
| Path | csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Arnd Bergmann <arnd@arndb.de> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/9] timers: provide a "modern" variant of timers |
| Date | Thu, 18 May 2017 11:00:01 +0200 |
| Message-ID | <tIprP-7UI-7@gated-at.bofh.it> (permalink) |
| References | <tHJ9f-56f-3@gated-at.bofh.it> <tHJiX-59w-29@gated-at.bofh.it> <tHQX8-1J7-23@gated-at.bofh.it> <tIoYN-7HX-9@gated-at.bofh.it> <tIpi9-7Qp-7@gated-at.bofh.it> |
| X-Original-To | Christoph Hellwig <hch@lst.de> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=qW1UtSO5ShJlojvvvHpJIWgLlKO2Q7GBdAyxMvgRCqA=; b=Ah9cT/fUjcweo6h6b7/luBw6/S93uTR3w+t2RewsOLltvvU5QxiUrOz77rAWthfYQQ Mrkql5PIzuDRNsl06CoeycQeXrU6OCdyGEqIITzHlJCypJDD9VviOk0WMF40SCJQvJCC MPKnfIFmxPc27ewEZjSQ/G/yYjbcCr4nfrbJS2xWvqTWPORy3ZsC0qq296Kd5PGMOn/a drQsz70+Qi5Xdi/hlaYKy3yhugjkpT+Y60Li8/55+r8FqsepQnPzd0EfMeqJxCd1KKL0 8nyI/PGcuw90htH2/D3fe3E2GdmX2lotoWySVzreWNkXtJbqZSOWJMrXyL/M7ASfRDch MTnA== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=qW1UtSO5ShJlojvvvHpJIWgLlKO2Q7GBdAyxMvgRCqA=; b=DRWLPlhpVTh3Ce65TbnK0R7737wbcaw628VEwG0DTRluXbwD+g27XCU5hLVc9gSSYv KNQCf/Dkyyt549nu4v5Zj5oJh2zxYsEqE3KyqBaeKjXDYeEYd+2Ajy2U1t+W0jqfNKSX 7EU1A4I3tNnNRRiMsr6Pedavk11RHA8lD7WXc+zkuHaSNAqO6vKSlFpv2+fjmLSJ5gxp 4+PSh2J0teQ7PKfP8h7QBuJ7UYyl8bIzJeRVrCRfZ9nwJVGzY8v1G2TSdUDpJLaWjSUa yCwktg8qPWtfj+FNx0uI3n7Nq3ibXhMvvm50wrqcWMt7cQmb78CKInuN3+fb9b5sNK1r wYGA== |
| X-Gm-Message-State | AODbwcAhKR+mD5D5lzFlOfCVyqYywEs5OoziESHGWZMxTP2Z04pH2m56 aaLr6zU+e8LiAHacztNrTKFpNSQnPA== |
| X-Received | by 10.202.72.17 with SMTP id v17mr1716271oia.78.1495097851702; Thu, 18 May 2017 01:57:31 -0700 (PDT) |
| MIME-Version | 1.0 |
| X-Google-Sender-Auth | dcCbZ8A--mXjILm3O-4dTbDnYFs |
| Content-Type | text/plain; charset="UTF-8" |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 20 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Thomas Gleixner <tglx@linutronix.de>, Mark Gross <mark.gross@intel.com>, Tejun Heo <tj@kernel.org>, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>, linux-s390 <linux-s390@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> |
| X-Original-Date | Thu, 18 May 2017 10:57:31 +0200 |
| X-Original-Message-ID | <CAK8P3a2ddbr=ck+G+80vGkVQ+L3snWkT1bbj2+1T6UJhm+_mrQ@mail.gmail.com> |
| X-Original-References | <20170516114812.10660-1-hch@lst.de> <20170516114812.10660-3-hch@lst.de> <CAK8P3a106wR4h_muGGF7S7uh5UrH-OcJObMfVgk22P9brP5Bjg@mail.gmail.com> <20170518082448.GB3812@lst.de> <20170518084136.GA5331@lst.de> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1643986 |
Show key headers only | View raw
On Thu, May 18, 2017 at 10:41 AM, Christoph Hellwig <hch@lst.de> wrote:
> On Thu, May 18, 2017 at 10:24:48AM +0200, Christoph Hellwig wrote:
>> > b) give the union a name (breaks any reference to timer_list->func in C code):
>> >
>> > + union {
>> > + void (*func)(struct timer_list *timer);
>> > + void (*function)(unsigned long);
>> > + } u;
>>
>> I'll look into that, as it seems a lot safer, and places outside
>> the timer code shouldn't really touch it (although I bet they do,
>> so more fixes for this series..)
>
> Meh. All the old init_timer users set function directly, so
> I guess we need to use the other approach.
How expensive would it be to add another field to timer_list and
just have both pointers?
Arnd
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
RFC: better timer interface Christoph Hellwig <hch@lst.de> - 2017-05-16 13:50 +0200
[PATCH 3/9] kthread: remove unused macros Christoph Hellwig <hch@lst.de> - 2017-05-16 13:50 +0200
Re: [PATCH 3/9] kthread: remove unused macros Petr Mladek <pmladek@suse.com> - 2017-05-17 14:20 +0200
Re: [PATCH 3/9] kthread: remove unused macros Christoph Hellwig <hch@lst.de> - 2017-05-18 10:30 +0200
[PATCH 8/9] tlclk: switch switchover_timer to a modern timer Christoph Hellwig <hch@lst.de> - 2017-05-16 13:50 +0200
[PATCH 6/9] s390: switch topology_timer to a modern timer Christoph Hellwig <hch@lst.de> - 2017-05-16 13:50 +0200
[PATCH 4/9] workqueue: switch to modern timers Christoph Hellwig <hch@lst.de> - 2017-05-16 13:50 +0200
[PATCH 7/9] s390: switch lgr timer to a modern timer Christoph Hellwig <hch@lst.de> - 2017-05-16 13:50 +0200
[PATCH 9/9] timers: remove old timer initialization macros Christoph Hellwig <hch@lst.de> - 2017-05-16 13:50 +0200
Re: [PATCH 9/9] timers: remove old timer initialization macros Arnd Bergmann <arnd@arndb.de> - 2017-05-16 21:50 +0200
Re: [PATCH 9/9] timers: remove old timer initialization macros Christoph Hellwig <hch@lst.de> - 2017-05-18 10:30 +0200
[PATCH 2/9] timers: provide a "modern" variant of timers Christoph Hellwig <hch@lst.de> - 2017-05-16 14:00 +0200
Re: [PATCH 2/9] timers: provide a "modern" variant of timers Randy Dunlap <rdunlap@infradead.org> - 2017-05-16 21:30 +0200
Re: [PATCH 2/9] timers: provide a "modern" variant of timers Arnd Bergmann <arnd@arndb.de> - 2017-05-16 22:10 +0200
Re: [PATCH 2/9] timers: provide a "modern" variant of timers Christoph Hellwig <hch@lst.de> - 2017-05-18 10:30 +0200
Re: [PATCH 2/9] timers: provide a "modern" variant of timers Christoph Hellwig <hch@lst.de> - 2017-05-18 10:50 +0200
Re: [PATCH 2/9] timers: provide a "modern" variant of timers Arnd Bergmann <arnd@arndb.de> - 2017-05-18 11:00 +0200
Re: [PATCH 2/9] timers: provide a "modern" variant of timers Christoph Hellwig <hch@lst.de> - 2017-05-21 09:10 +0200
Re: [PATCH 2/9] timers: provide a "modern" variant of timers Arnd Bergmann <arnd@arndb.de> - 2017-05-21 14:30 +0200
Re: [PATCH 2/9] timers: provide a "modern" variant of timers Thomas Gleixner <tglx@linutronix.de> - 2017-05-21 20:00 +0200
Re: [PATCH 2/9] timers: provide a "modern" variant of timers Al Viro <viro@ZenIV.linux.org.uk> - 2017-05-21 20:30 +0200
RE: [PATCH 2/9] timers: provide a "modern" variant of timers David Laight <David.Laight@ACULAB.COM> - 2017-05-19 12:50 +0200
Re: [PATCH 2/9] timers: provide a "modern" variant of timers 'Christoph Hellwig' <hch@lst.de> - 2017-05-21 09:00 +0200
[PATCH 5/9] powerpc/numa: switch topology_timer to modern timer Christoph Hellwig <hch@lst.de> - 2017-05-16 14:00 +0200
Re: RFC: better timer interface Arnd Bergmann <arnd@arndb.de> - 2017-05-16 17:50 +0200
Re: RFC: better timer interface Christoph Hellwig <hch@lst.de> - 2017-05-16 18:00 +0200
Re: RFC: better timer interface Arnd Bergmann <arnd@arndb.de> - 2017-05-16 22:30 +0200
Re: RFC: better timer interface Christoph Hellwig <hch@lst.de> - 2017-05-18 10:30 +0200
Re: RFC: better timer interface Thomas Gleixner <tglx@linutronix.de> - 2017-05-21 19:20 +0200
Re: RFC: better timer interface Thomas Gleixner <tglx@linutronix.de> - 2017-05-21 20:20 +0200
Re: RFC: better timer interface Arnd Bergmann <arnd@arndb.de> - 2017-05-22 13:30 +0200
Re: RFC: better timer interface Thomas Gleixner <tglx@linutronix.de> - 2017-05-22 21:30 +0200
RE: RFC: better timer interface David Laight <David.Laight@ACULAB.COM> - 2017-05-23 13:40 +0200
RE: RFC: better timer interface Thomas Gleixner <tglx@linutronix.de> - 2017-05-23 14:00 +0200
RE: RFC: better timer interface David Laight <David.Laight@ACULAB.COM> - 2017-05-23 15:00 +0200
RE: RFC: better timer interface Thomas Gleixner <tglx@linutronix.de> - 2017-05-23 15:10 +0200
Re: RFC: better timer interface Arnd Bergmann <arnd@arndb.de> - 2017-05-22 15:40 +0200
Re: RFC: better timer interface Thomas Gleixner <tglx@linutronix.de> - 2017-05-22 21:20 +0200
csiph-web