Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1643999

Re: [PATCH] staging: iio: light: Replace symbolic permissions as per coding style

From Greg KH <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH] staging: iio: light: Replace symbolic permissions as per coding style
Date 2017-05-18 11:10 +0200
Message-ID <tIpBw-8eh-31@gated-at.bofh.it> (permalink)
References <tIp8v-7LV-41@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Thu, May 18, 2017 at 02:06:29PM +0530, surenderpolsani@gmail.com wrote:
> From: Surender Polsani <surenderpolsani@gmail.com>
> 
> Fixed the following checkpatch.pl warnings:
> octal permissions are more preferable than symbolic permissions
> 
> Signed-off-by: Surender Polsani <surenderpolsani@gmail.com>
> ---
>  drivers/staging/iio/light/tsl2x7x_core.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/iio/light/tsl2x7x_core.c b/drivers/staging/iio/light/tsl2x7x_core.c
> index af3910b..c63fe6a 100644
> --- a/drivers/staging/iio/light/tsl2x7x_core.c
> +++ b/drivers/staging/iio/light/tsl2x7x_core.c
> @@ -1498,34 +1498,34 @@ static int tsl2x7x_write_raw(struct iio_dev *indio_dev,
>  	return 0;
>  }
>  
> -static DEVICE_ATTR(power_state, S_IRUGO | S_IWUSR,
> +static DEVICE_ATTR(power_state, 0644,
>  		tsl2x7x_power_state_show, tsl2x7x_power_state_store);

How about using DEVICE_ATTR_RW() and DEVICE_ATTR_RO() instead?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: iio: light: Replace symbolic permissions as per coding style surenderpolsani@gmail.com - 2017-05-18 10:40 +0200
  Re: [PATCH] staging: iio: light: Replace symbolic permissions as per  coding style Greg KH <gregkh@linuxfoundation.org> - 2017-05-18 11:10 +0200
    [PATCH v2] staging: iio: light: Replace symbolic permissions as per coding style surenderpolsani@gmail.com - 2017-05-19 09:10 +0200
      Re: [PATCH v2] staging: iio: light: Replace symbolic permissions as  per coding style Greg KH <gregkh@linuxfoundation.org> - 2017-05-19 09:20 +0200
        Re: [PATCH v2] staging: iio: light: Replace symbolic permissions as  per coding style suri <surenderpolsani@gmail.com> - 2017-05-19 09:40 +0200
    [PATCH v2] staging: iio: light: Replace symbolic permissions as per coding style surenderpolsani@gmail.com - 2017-05-19 10:20 +0200
      Re: [PATCH v2] staging: iio: light: Replace symbolic permissions as  per coding style Greg KH <gregkh@linuxfoundation.org> - 2017-05-19 10:30 +0200
        [PATCH v3] staging: iio: light: Replace symbolic permissions as per coding style surenderpolsani@gmail.com - 2017-05-19 11:40 +0200
          Re: [PATCH v3] staging: iio: light: Replace symbolic permissions as  per coding style Jonathan Cameron <jic23@kernel.org> - 2017-05-20 20:00 +0200
            Re: [PATCH v3] staging: iio: light: Replace symbolic permissions as  per coding style Brian Masney <masneyb@onstation.org> - 2017-05-20 20:40 +0200
              Re: [PATCH v3] staging: iio: light: Replace symbolic permissions as  per coding style Jonathan Cameron <jic23@kernel.org> - 2017-05-21 13:00 +0200

csiph-web