Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1645255

[PATCH v2] staging: iio: light: Replace symbolic permissions as per coding style

Show all headers | View raw

From: Surender Polsani <surenderpolsani@gmail.com>

Fixed the following checkpatch.pl warnings:
octal permissions are more preferable than symbolic permissions

Replaced DEVICE_ATTR family macros with DEVICE_ATTR_RW family
as suggested by Greg K-H. Changed attributes and function
names where ever required to satisfy internal macro definitions
like __ATTR__RW().

Signed-off-by: Surender Polsani <surenderpolsani@gmail.com>
---
Changes for v2:

- Made few changes as suggested by Greg K-H and modified
  description accordingly.
---
 drivers/staging/iio/light/tsl2x7x_core.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/iio/light/tsl2x7x_core.c b/drivers/staging/iio/light/tsl2x7x_core.c
index af3910b..c63fe6a 100644
--- a/drivers/staging/iio/light/tsl2x7x_core.c
+++ b/drivers/staging/iio/light/tsl2x7x_core.c
@@ -1498,34 +1498,34 @@ static int tsl2x7x_write_raw(struct iio_dev *indio_dev,
 	return 0;
 }
 
-static DEVICE_ATTR(power_state, S_IRUGO | S_IWUSR,
+static DEVICE_ATTR(power_state, 0644,
 		tsl2x7x_power_state_show, tsl2x7x_power_state_store);
 
-static DEVICE_ATTR(in_proximity0_calibscale_available, S_IRUGO,
+static DEVICE_ATTR(in_proximity0_calibscale_available, 0444,
 		tsl2x7x_prox_gain_available_show, NULL);
 
-static DEVICE_ATTR(in_illuminance0_calibscale_available, S_IRUGO,
+static DEVICE_ATTR(in_illuminance0_calibscale_available, 0444,
 		tsl2x7x_gain_available_show, NULL);
 
-static DEVICE_ATTR(in_illuminance0_integration_time, S_IRUGO | S_IWUSR,
+static DEVICE_ATTR(in_illuminance0_integration_time, 0644,
 		tsl2x7x_als_time_show, tsl2x7x_als_time_store);
 
-static DEVICE_ATTR(in_illuminance0_target_input, S_IRUGO | S_IWUSR,
+static DEVICE_ATTR(in_illuminance0_target_input, 0644,
 		tsl2x7x_als_cal_target_show, tsl2x7x_als_cal_target_store);
 
-static DEVICE_ATTR(in_illuminance0_calibrate, S_IWUSR, NULL,
+static DEVICE_ATTR(in_illuminance0_calibrate, 0200, NULL,
 		tsl2x7x_do_calibrate);
 
-static DEVICE_ATTR(in_proximity0_calibrate, S_IWUSR, NULL,
+static DEVICE_ATTR(in_proximity0_calibrate, 0200, NULL,
 		tsl2x7x_do_prox_calibrate);
 
-static DEVICE_ATTR(in_illuminance0_lux_table, S_IRUGO | S_IWUSR,
+static DEVICE_ATTR(in_illuminance0_lux_table, 0644,
 		tsl2x7x_luxtable_show, tsl2x7x_luxtable_store);
 
-static DEVICE_ATTR(in_intensity0_thresh_period, S_IRUGO | S_IWUSR,
+static DEVICE_ATTR(in_intensity0_thresh_period, 0644,
 		tsl2x7x_als_persistence_show, tsl2x7x_als_persistence_store);
 
-static DEVICE_ATTR(in_proximity0_thresh_period, S_IRUGO | S_IWUSR,
+static DEVICE_ATTR(in_proximity0_thresh_period, 0644,
 		tsl2x7x_prox_persistence_show, tsl2x7x_prox_persistence_store);
 
 /* Use the default register values to identify the Taos device */
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: iio: light: Replace symbolic permissions as per coding style surenderpolsani@gmail.com - 2017-05-18 10:40 +0200
  Re: [PATCH] staging: iio: light: Replace symbolic permissions as per  coding style Greg KH <gregkh@linuxfoundation.org> - 2017-05-18 11:10 +0200
    [PATCH v2] staging: iio: light: Replace symbolic permissions as per coding style surenderpolsani@gmail.com - 2017-05-19 09:10 +0200
      Re: [PATCH v2] staging: iio: light: Replace symbolic permissions as  per coding style Greg KH <gregkh@linuxfoundation.org> - 2017-05-19 09:20 +0200
        Re: [PATCH v2] staging: iio: light: Replace symbolic permissions as  per coding style suri <surenderpolsani@gmail.com> - 2017-05-19 09:40 +0200
    [PATCH v2] staging: iio: light: Replace symbolic permissions as per coding style surenderpolsani@gmail.com - 2017-05-19 10:20 +0200
      Re: [PATCH v2] staging: iio: light: Replace symbolic permissions as  per coding style Greg KH <gregkh@linuxfoundation.org> - 2017-05-19 10:30 +0200
        [PATCH v3] staging: iio: light: Replace symbolic permissions as per coding style surenderpolsani@gmail.com - 2017-05-19 11:40 +0200
          Re: [PATCH v3] staging: iio: light: Replace symbolic permissions as  per coding style Jonathan Cameron <jic23@kernel.org> - 2017-05-20 20:00 +0200
            Re: [PATCH v3] staging: iio: light: Replace symbolic permissions as  per coding style Brian Masney <masneyb@onstation.org> - 2017-05-20 20:40 +0200
              Re: [PATCH v3] staging: iio: light: Replace symbolic permissions as  per coding style Jonathan Cameron <jic23@kernel.org> - 2017-05-21 13:00 +0200

csiph-web