Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32
Date	2017-05-18 10:10 +0200
Message-ID	<tIoFr-7xF-1@gated-at.bofh.it> (permalink)
References	<tGanf-7y4-3@gated-at.bofh.it> <tGanf-7y4-7@gated-at.bofh.it> <tIbIe-6xR-15@gated-at.bofh.it> <tIewq-8p4-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, May 17, 2017 at 09:16:47PM +0000, Chris Packham wrote:
> MV64x60 is pretty old. I considered gutting mv64x60_edac.c to make a 
> separate driver but that would just be more code to maintain.

Well, one thing we did with layerscape and mpc85xx EDAC modules is share
the FSL memory controller IP through fsl_ddr_edac.c which both modules
link.

I dunno, perhaps you could do something similar by extracting the common
parts and this way avoid any breakage of the PPC side of things - since
apparently finding such hw is not easy - and then link those into your
driver. And your driver could just be a wrapper containing the EDAC glue
to make it a separate ARM armada_edac.c or so.

Anyway, just an idea.

Thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Thread

[PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32 Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-05-12 06:30 +0200
  Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with  ioread32/iowrite32 Borislav Petkov <bp@alien8.de> - 2017-05-17 20:20 +0200
    Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with  ioread32/iowrite32 Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-05-17 23:20 +0200
      Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32 Arnd Bergmann <arnd@arndb.de> - 2017-05-17 23:50 +0200
        RE: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with  ioread32/iowrite32 David Laight <David.Laight@ACULAB.COM> - 2017-05-19 16:10 +0200
          Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32 Arnd Bergmann <arnd@arndb.de> - 2017-05-19 17:30 +0200
      Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with  ioread32/iowrite32 Borislav Petkov <bp@alien8.de> - 2017-05-18 10:10 +0200
    Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32 Michael Ellerman <mpe@ellerman.id.au> - 2017-05-18 07:40 +0200
      Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32 Arnd Bergmann <arnd@arndb.de> - 2017-05-18 13:10 +0200
        Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32 Michael Ellerman <mpe@ellerman.id.au> - 2017-05-19 12:00 +0200

csiph-web