Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1645481

Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32

Show all headers | View raw

Arnd Bergmann <arnd@arndb.de> writes:

> On Thu, May 18, 2017 at 7:36 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>> Borislav Petkov <bp@alien8.de> writes:
>>
>>> Top-posting so that the PPC list can see the whole patch below.
>>>
>>> Since I don't know PPC, let me add PPC ML to CC for a confirmation this
>>> change is correct.
>>>
>>> Which brings me to the tangential: this driver is from 2006-ish and
>>> is for some "Marvell MV64x60 Memory Controller kernel module for PPC
>>> platforms". If you're going to touch it, then you should test on the PPC
>>> hardware too, so that you don't break the driver there.
>>>
>>> Unless that hardware is obsolete now and we don't care and, and ..?
>>>
>>> Maybe someone has some insights...
>>
>> Not really sorry.
>>
>> I don't have one of those boards, so I can't test. Maybe someone else on
>> the list does?
>>
>> I'd err on the side of the PPC hardware being obsolete and no one really
>> caring. If the driver is helpful on ARM then we may as well use it
>> there, if we can also avoid breaking it on PPC then great.
>
> I never had one myself, but tried to figure out what is still there to be
> supported. In 2014, we removed one platform (PrPMC2800) that was
> obsolete. There were eight boards that didn't make the cut from
> arch/ppc32 to arch/powerpc. The C2K is the last one and it was
> added in 2008 with this comment:
>
>     Support for the C2K cPCI Single Board Computer from GEFanuc
>     (PowerPC MPC7448 with a Marvell MV64460 chipset).
>     All features of the board are not supported yet, but the board
>     boots, flash works, all Ethernet ports are working and PCI
>     devices are all found (USB and SATA on PCI1 do not work yet).
>
>     Part 3 of 5: driver for the board.  At this time it is very generic
>     and similar to its original, the driver for the prpmc2800.
>
> The original submitter never followed up on it and neither the
> board code not the DTS was ever updated to include additional
> features, so I assume it only got worse from there.
>
> According to https://www.abaco.com/products/c2ka-compactpci-sbc
> the end-of-life date for the product was in 2015, presumably 10 years
> after it got introduced.
>
> This is definitely obsolete by now, and given the missing features
> I would assume that nobody is running mainline kernels on it and
> it can be removed.

Great, thanks for doing all that digging.

I'll cook up a patch to remove c2k next week.

Then we can drop CONFIG_MV64X60 from PPC and see where that leaves
things, depending on what's useful on ARM.

cheers

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32 Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-05-12 06:30 +0200
  Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with  ioread32/iowrite32 Borislav Petkov <bp@alien8.de> - 2017-05-17 20:20 +0200
    Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with  ioread32/iowrite32 Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-05-17 23:20 +0200
      Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32 Arnd Bergmann <arnd@arndb.de> - 2017-05-17 23:50 +0200
        RE: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with  ioread32/iowrite32 David Laight <David.Laight@ACULAB.COM> - 2017-05-19 16:10 +0200
          Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32 Arnd Bergmann <arnd@arndb.de> - 2017-05-19 17:30 +0200
      Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with  ioread32/iowrite32 Borislav Petkov <bp@alien8.de> - 2017-05-18 10:10 +0200
    Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32 Michael Ellerman <mpe@ellerman.id.au> - 2017-05-18 07:40 +0200
      Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32 Arnd Bergmann <arnd@arndb.de> - 2017-05-18 13:10 +0200
        Re: [PATCH 3/3] EDAC: mv64x60: replace in_le32/out_le32 with ioread32/iowrite32 Michael Ellerman <mpe@ellerman.id.au> - 2017-05-19 12:00 +0200

csiph-web