Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1643812

Re: [PATCH] scsi: remove useless variable assignment

Show all headers | View raw

On Wed, 2017-05-17 at 19:30 -0500, Gustavo A. R. Silva wrote:
> Remove this assignment once the value stored in variable _k_ is
> overwritten after a few lines.
> 
> Addresses-Coverity-ID: 1226927
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
>  drivers/scsi/qlogicfas408.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/scsi/qlogicfas408.c
> b/drivers/scsi/qlogicfas408.c
> index c3a9151..269440a 100644
> --- a/drivers/scsi/qlogicfas408.c
> +++ b/drivers/scsi/qlogicfas408.c
> @@ -329,7 +329,6 @@ static unsigned int ql_pcmd(struct scsi_cmnd
> *cmd)
>  		 */
>  		if ((k = ql_wai(priv)))
>  			return (k << 16);
> -		k = inb(qbase + 5);	/* should be 0x10, bus
> service */

That doesn't look right to me.  inb() is a statement which has an
effect on the I/O device regardless of whether the returned value is
used or discarded.  In this case I think it's being used to clear
pending interrupts, so removing it will likely cause a phase error.

James

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] scsi: remove useless variable assignment "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-18 02:40 +0200
  Re: [PATCH] scsi: remove useless variable assignment James Bottomley <jejb@linux.vnet.ibm.com> - 2017-05-18 06:50 +0200
    Re: [PATCH] scsi: remove useless variable assignment "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-18 19:50 +0200

csiph-web