Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1645763
| From | Shiraz Saleem <shiraz.saleem@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] infiniband: hw: i40iw: fix duplicated code for different branches |
| Date | 2017-05-19 19:00 +0200 |
| Message-ID | <tITpU-4T3-5@gated-at.bofh.it> (permalink) |
| References | <tIxSq-5YL-1@gated-at.bofh.it> <tIybM-6nh-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, May 18, 2017 at 01:11:17PM -0500, Gustavo A. R. Silva wrote:
> Refactor code to avoid identical code for different branches.
>
> Addresses-Coverity-ID: 1357356
> Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/infiniband/hw/i40iw/i40iw_virtchnl.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/infiniband/hw/i40iw/i40iw_virtchnl.c b/drivers/infiniband/hw/i40iw/i40iw_virtchnl.c
> index f4d1368..48fd327 100644
> --- a/drivers/infiniband/hw/i40iw/i40iw_virtchnl.c
> +++ b/drivers/infiniband/hw/i40iw/i40iw_virtchnl.c
> @@ -443,10 +443,7 @@ enum i40iw_status_code i40iw_vchnl_recv_pf(struct i40iw_sc_dev *dev,
> if (!dev->vchnl_up)
> return I40IW_ERR_NOT_READY;
> if (vchnl_msg->iw_op_code == I40IW_VCHNL_OP_GET_VER) {
> - if (vchnl_msg->iw_op_ver != I40IW_VCHNL_OP_GET_VER_V0)
> - vchnl_pf_send_get_ver_resp(dev, vf_id, vchnl_msg);
> - else
> - vchnl_pf_send_get_ver_resp(dev, vf_id, vchnl_msg);
> + vchnl_pf_send_get_ver_resp(dev, vf_id, vchnl_msg);
> return I40IW_SUCCESS;
> }
> for (iw_vf_idx = 0; iw_vf_idx < I40IW_MAX_PE_ENABLED_VF_COUNT; iw_vf_idx++) {
> --
Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[infiniband-hw-i40iw] question about identical code for different branches "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-18 00:10 +0200
Re: [infiniband-hw-i40iw] question about identical code for different branches Yuval Shaia <yuval.shaia@oracle.com> - 2017-05-18 08:10 +0200
Re: [infiniband-hw-i40iw] question about identical code for different branches Leon Romanovsky <leon@kernel.org> - 2017-05-18 08:40 +0200
Re: [infiniband-hw-i40iw] question about identical code for different branches Chien Tin Tung <chien.tin.tung@intel.com> - 2017-05-18 17:10 +0200
RE: [infiniband-hw-i40iw] question about identical code for different branches "Saleem, Shiraz" <shiraz.saleem@intel.com> - 2017-05-18 16:40 +0200
Re: [infiniband-hw-i40iw] question about identical code for different branches "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-18 20:00 +0200
[PATCH] infiniband: hw: i40iw: fix duplicated code for different branches "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-05-18 20:20 +0200
Re: [PATCH] infiniband: hw: i40iw: fix duplicated code for different branches Shiraz Saleem <shiraz.saleem@intel.com> - 2017-05-19 19:00 +0200
csiph-web