Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1645451
| From | Matthias Brugger <matthias.bgg@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 8/9] crypto: mediatek - Use IPAD/OPAD constant |
| Date | 2017-05-19 11:20 +0200 |
| Message-ID | <tIMeK-8ro-13@gated-at.bofh.it> (permalink) |
| References | <tIK3f-6Oj-1@gated-at.bofh.it> <tIK3h-6Oj-35@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 19/05/17 08:53, Corentin Labbe wrote:
> This patch simply replace all occurrence of HMAC IPAD/OPAD value by their
> define.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> drivers/crypto/mediatek/mtk-sha.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/mediatek/mtk-sha.c b/drivers/crypto/mediatek/mtk-sha.c
> index 2226f12d1c7a..5f4f845adbb8 100644
> --- a/drivers/crypto/mediatek/mtk-sha.c
> +++ b/drivers/crypto/mediatek/mtk-sha.c
> @@ -12,6 +12,7 @@
> * Some ideas are from atmel-sha.c and omap-sham.c drivers.
> */
>
> +#include <crypto/hmac.h>
> #include <crypto/sha.h>
> #include "mtk-platform.h"
>
> @@ -825,8 +826,8 @@ static int mtk_sha_setkey(struct crypto_ahash *tfm, const u8 *key,
> memcpy(bctx->opad, bctx->ipad, bs);
>
> for (i = 0; i < bs; i++) {
> - bctx->ipad[i] ^= 0x36;
> - bctx->opad[i] ^= 0x5c;
> + bctx->ipad[i] ^= HMAC_IPAD_VALUE;
> + bctx->opad[i] ^= HMAC_OPAD_VALUE;
> }
>
> return 0;
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/9] crypto: add HMAC IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-19 09:00 +0200
[PATCH v2 9/9] crypto: ccp - Use IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-19 09:00 +0200
[PATCH v2 7/9] crypto: qat - Use IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-19 09:00 +0200
[PATCH v2 5/9] crypto: mv_cesa - Use IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-19 09:00 +0200
[PATCH v2 2/9] crypto: brcm - Use IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-19 09:00 +0200
[PATCH v2 4/9] crypto: marvell - Use IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-19 09:00 +0200
Re: [PATCH v2 4/9] crypto: marvell - Use IPAD/OPAD constant Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-19 11:20 +0200
[PATCH v2 6/9] crypto: omap-sham - Use IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-19 09:00 +0200
[PATCH v2 3/9] crypto: ixp4xx - Use IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-19 09:00 +0200
[PATCH v2 1/9] crypto: add hmac IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-19 09:00 +0200
[PATCH v2 8/9] crypto: mediatek - Use IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-19 09:00 +0200
Re: [PATCH v2 8/9] crypto: mediatek - Use IPAD/OPAD constant Matthias Brugger <matthias.bgg@gmail.com> - 2017-05-19 11:20 +0200
Re: [PATCH v2 0/9] crypto: add HMAC IPAD/OPAD constant Herbert Xu <herbert@gondor.apana.org.au> - 2017-05-23 07:10 +0200
csiph-web