Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1645447

Re: [PATCH v2 4/9] crypto: marvell - Use IPAD/OPAD constant

From Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 4/9] crypto: marvell - Use IPAD/OPAD constant
Date 2017-05-19 11:20 +0200
Message-ID <tIMeJ-8ro-1@gated-at.bofh.it> (permalink)
References <tIK3f-6Oj-1@gated-at.bofh.it> <tIK3g-6Oj-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, 19 May 2017 08:53:26 +0200
Corentin Labbe <clabbe.montjoie@gmail.com> wrote:

> This patch simply replace all occurrence of HMAC IPAD/OPAD value by their
> define.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>

Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

> ---
>  drivers/crypto/marvell/hash.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/marvell/hash.c b/drivers/crypto/marvell/hash.c
> index 77c0fb936f47..e61b08566093 100644
> --- a/drivers/crypto/marvell/hash.c
> +++ b/drivers/crypto/marvell/hash.c
> @@ -12,6 +12,7 @@
>   * by the Free Software Foundation.
>   */
>  
> +#include <crypto/hmac.h>
>  #include <crypto/md5.h>
>  #include <crypto/sha.h>
>  
> @@ -1164,8 +1165,8 @@ static int mv_cesa_ahmac_pad_init(struct ahash_request *req,
>  	memcpy(opad, ipad, blocksize);
>  
>  	for (i = 0; i < blocksize; i++) {
> -		ipad[i] ^= 0x36;
> -		opad[i] ^= 0x5c;
> +		ipad[i] ^= HMAC_IPAD_VALUE;
> +		opad[i] ^= HMAC_OPAD_VALUE;
>  	}
>  
>  	return 0;

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/9] crypto: add HMAC IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-19 09:00 +0200
  [PATCH v2 9/9] crypto: ccp - Use IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-19 09:00 +0200
  [PATCH v2 7/9] crypto: qat - Use IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-19 09:00 +0200
  [PATCH v2 5/9] crypto: mv_cesa - Use IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-19 09:00 +0200
  [PATCH v2 2/9] crypto: brcm - Use IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-19 09:00 +0200
  [PATCH v2 4/9] crypto: marvell - Use IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-19 09:00 +0200
    Re: [PATCH v2 4/9] crypto: marvell - Use IPAD/OPAD constant Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-19 11:20 +0200
  [PATCH v2 6/9] crypto: omap-sham - Use IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-19 09:00 +0200
  [PATCH v2 3/9] crypto: ixp4xx - Use IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-19 09:00 +0200
  [PATCH v2 1/9] crypto: add hmac IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-19 09:00 +0200
  [PATCH v2 8/9] crypto: mediatek - Use IPAD/OPAD constant Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-05-19 09:00 +0200
    Re: [PATCH v2 8/9] crypto: mediatek - Use IPAD/OPAD constant Matthias Brugger <matthias.bgg@gmail.com> - 2017-05-19 11:20 +0200
  Re: [PATCH v2 0/9] crypto: add HMAC IPAD/OPAD constant Herbert Xu <herbert@gondor.apana.org.au> - 2017-05-23 07:10 +0200

csiph-web