Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1645377

Re: [PATCH] firmware: ti_sci: fix strncat length check

Show all headers | View raw

On Tue, Mar 14, 2017 at 10:19 PM, santosh.shilimkar@oracle.com
<santosh.shilimkar@oracle.com> wrote:
> On 3/14/17 2:11 PM, Arnd Bergmann wrote:
>>
>> gcc-7 notices that the length we pass to strncat is wrong:
>>
>> drivers/firmware/ti_sci.c: In function 'ti_sci_probe':
>> drivers/firmware/ti_sci.c:204:32: error: specified bound 50 equals the
>> size of the destination [-Werror=stringop-overflow=]
>>
>> Instead of the total length, we must pass the length of the
>> remaining space here.
>>
>> Fixes: aa276781a64a ("firmware: Add basic support for TI System Control
>> Interface (TI-SCI) protocol")
>> Acked-by: Nishanth Menon <nm@ti.com>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> Originally submitted on Jan 11, patch is still needed on Linux-4.11-rc2.
>
>
> Looks fine to me Arnd. Will you be applying it to SOC driver branch ?
>
> Acked-by: Santosh Shilimkar <ssantosh@kernel.org>

For some reason I dropped the ball in this patch, applied to arm-soc fixes
now and marked for stable backports.

        Arnd

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] firmware: ti_sci: fix strncat length check Arnd Bergmann <arnd@arndb.de> - 2017-05-19 10:40 +0200

csiph-web