Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1645133

Re: [PATCH 1/6] kernel/locking: Fix compile error with qrwlock.c

Show all headers | View raw

From: Babu Moger <babu.moger@oracle.com>
Date: Thu, 18 May 2017 18:36:05 -0600

> Seeing this error on SPARC while compiling qrwlock.c.
> 
>   CC      kernel/locking/qrwlock.o
> In file included from ./include/asm-generic/qrwlock_types.h:5,
>                  from ./arch/sparc/include/asm/qrwlock.h:4,
>                  from kernel/locking/qrwlock.c:24:
> ./arch/sparc/include/asm/spinlock_types.h:5:3: error:
>         #error "please don't include this file directly"
> 
> Re-arrange the includes in qrwlock_types.h and also include spinlock.h
> in qrwlock.c to fix it. This should also help other architectures when
> queued rwlock is enabled.
> 
> Signed-off-by: Babu Moger <babu.moger@oracle.com>
> Reviewed-by: Håkon Bugge <haakon.bugge@oracle.com>
> Reviewed-by: Jane Chu <jane.chu@oracle.com>
> Reviewed-by: Shannon Nelson <shannon.nelson@oracle.com>
> Reviewed-by: Vijay Kumar <vijay.ac.kumar@oracle.com>

I think you can simply remove the:

#ifndef __LINUX_SPINLOCK_TYPES_H
# error "please don't include this file directly"
#endif

stanza from the sparc header file instead.  Other architectures
don't use this guard.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] Enable queued rwlock and queued spinlock for SPARC Babu Moger <babu.moger@oracle.com> - 2017-05-19 02:40 +0200
  [PATCH 3/6] arch/sparc: Introduce cmpxchg_u8 SPARC Babu Moger <babu.moger@oracle.com> - 2017-05-19 02:40 +0200
  [PATCH 6/6] arch/sparc: Enable queued spinlock support for SPARC Babu Moger <babu.moger@oracle.com> - 2017-05-19 02:40 +0200
    Re: [PATCH 6/6] arch/sparc: Enable queued spinlock support for  SPARC David Miller <davem@davemloft.net> - 2017-05-19 04:40 +0200
      Re: [PATCH 6/6] arch/sparc: Enable queued spinlock support for SPARC Babu Moger <babu.moger@oracle.com> - 2017-05-19 18:40 +0200
  [PATCH 2/6] arch/sparc: Define config parameter CPU_BIG_ENDIAN Babu Moger <babu.moger@oracle.com> - 2017-05-19 02:40 +0200
    Re: [PATCH 2/6] arch/sparc: Define config parameter CPU_BIG_ENDIAN David Miller <davem@davemloft.net> - 2017-05-19 04:30 +0200
      Re: [PATCH 2/6] arch/sparc: Define config parameter CPU_BIG_ENDIAN Babu Moger <babu.moger@oracle.com> - 2017-05-19 18:30 +0200
  [PATCH 1/6] kernel/locking: Fix compile error with qrwlock.c Babu Moger <babu.moger@oracle.com> - 2017-05-19 02:40 +0200
    Re: [PATCH 1/6] kernel/locking: Fix compile error with qrwlock.c David Miller <davem@davemloft.net> - 2017-05-19 04:30 +0200
      Re: [PATCH 1/6] kernel/locking: Fix compile error with qrwlock.c Babu Moger <babu.moger@oracle.com> - 2017-05-19 18:40 +0200
  [PATCH 4/6] arch/sparc: Enable queued rwlocks for SPARC Babu Moger <babu.moger@oracle.com> - 2017-05-19 02:40 +0200
    Re: [PATCH 4/6] arch/sparc: Enable queued rwlocks for SPARC David Miller <davem@davemloft.net> - 2017-05-19 04:40 +0200
      Re: [PATCH 4/6] arch/sparc: Enable queued rwlocks for SPARC Peter Zijlstra <peterz@infradead.org> - 2017-05-19 11:10 +0200
        Re: [PATCH 4/6] arch/sparc: Enable queued rwlocks for SPARC Babu Moger <babu.moger@oracle.com> - 2017-05-19 18:50 +0200
        Re: [PATCH 4/6] arch/sparc: Enable queued rwlocks for SPARC David Miller <davem@davemloft.net> - 2017-05-19 21:20 +0200
          Re: [PATCH 4/6] arch/sparc: Enable queued rwlocks for SPARC Peter Zijlstra <peterz@infradead.org> - 2017-05-19 21:40 +0200
            Re: [PATCH 4/6] arch/sparc: Enable queued rwlocks for SPARC David Miller <davem@davemloft.net> - 2017-05-19 21:40 +0200
      Re: [PATCH 4/6] arch/sparc: Enable queued rwlocks for SPARC Babu Moger <babu.moger@oracle.com> - 2017-05-19 18:40 +0200

csiph-web