Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1643453

Re: [PATCH v2 3/6] mm, page_alloc: pass preferred nid instead of zonelist to allocator

Show all headers | View raw

On Wed, 17 May 2017, Vlastimil Babka wrote:

>  struct page *
> -__alloc_pages_nodemask(gfp_t gfp_mask, unsigned int order,
> -		       struct zonelist *zonelist, nodemask_t *nodemask);
> +__alloc_pages_nodemask(gfp_t gfp_mask, unsigned int order, int preferred_nid,
> +							nodemask_t *nodemask);
>
>  static inline struct page *
> -__alloc_pages(gfp_t gfp_mask, unsigned int order,
> -		struct zonelist *zonelist)
> +__alloc_pages(gfp_t gfp_mask, unsigned int order, int preferred_nid)
>  {
> -	return __alloc_pages_nodemask(gfp_mask, order, zonelist, NULL);
> +	return __alloc_pages_nodemask(gfp_mask, order, preferred_nid, NULL);
>  }

Maybe use nid instead of preferred_nid like in __alloc_pages? Otherwise
there may be confusion with the MPOL_PREFER policy.

> @@ -1963,8 +1960,8 @@ alloc_pages_vma(gfp_t gfp, int order, struct vm_area_struct *vma,
>  {
>  	struct mempolicy *pol;
>  	struct page *page;
> +	int preferred_nid;
>  	unsigned int cpuset_mems_cookie;
> -	struct zonelist *zl;
>  	nodemask_t *nmask;

Same here.

> @@ -4012,8 +4012,8 @@ static inline void finalise_ac(gfp_t gfp_mask,
>   * This is the 'heart' of the zoned buddy allocator.
>   */
>  struct page *
> -__alloc_pages_nodemask(gfp_t gfp_mask, unsigned int order,
> -			struct zonelist *zonelist, nodemask_t *nodemask)
> +__alloc_pages_nodemask(gfp_t gfp_mask, unsigned int order, int preferred_nid,
> +							nodemask_t *nodemask)
>  {

and here

This looks clean to me. Still feel a bit uneasy about this since I do
remember that we had a reason to use zonelists instead of nodes back then
but cannot remember what that reason was....

CCing Dimitri at SGI. This may break a lot of legacy SGIapps. If you read
this Dimitri then please review this patchset and the discussions around
it.

Reviewed-by: Christoph Lameter <cl@linux.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/6] cpuset/mempolicies related fixes and cleanups Vlastimil Babka <vbabka@suse.cz> - 2017-05-17 10:20 +0200
  [PATCH v2 2/6] mm, mempolicy: stop adjusting current->il_next in mpol_rebind_nodemask() Vlastimil Babka <vbabka@suse.cz> - 2017-05-17 10:20 +0200
    Re: [PATCH v2 2/6] mm, mempolicy: stop adjusting current->il_next  in mpol_rebind_nodemask() Christoph Lameter <cl@linux.com> - 2017-05-17 17:10 +0200
  [PATCH v2 6/6] mm, mempolicy: don't check cpuset seqlock where it doesn't matter Vlastimil Babka <vbabka@suse.cz> - 2017-05-17 10:20 +0200
    Re: [PATCH v2 6/6] mm, mempolicy: don't check cpuset seqlock where  it doesn't matter Michal Hocko <mhocko@kernel.org> - 2017-05-23 09:20 +0200
  [PATCH v2 3/6] mm, page_alloc: pass preferred nid instead of zonelist to allocator Vlastimil Babka <vbabka@suse.cz> - 2017-05-17 10:20 +0200
    Re: [PATCH v2 3/6] mm, page_alloc: pass preferred nid instead of  zonelist to allocator Christoph Lameter <cl@linux.com> - 2017-05-17 17:20 +0200
      Re: [PATCH v2 3/6] mm, page_alloc: pass preferred nid instead of  zonelist to allocator Vlastimil Babka <vbabka@suse.cz> - 2017-05-18 12:30 +0200
    Re: [PATCH v2 3/6] mm, page_alloc: pass preferred nid instead of  zonelist to allocator Michal Hocko <mhocko@kernel.org> - 2017-05-19 14:00 +0200
  [PATCH v2 1/6] mm, page_alloc: fix more premature OOM due to race with cpuset update Vlastimil Babka <vbabka@suse.cz> - 2017-05-17 10:20 +0200
    Re: [PATCH v2 1/6] mm, page_alloc: fix more premature OOM due to  race with cpuset update Michal Hocko <mhocko@kernel.org> - 2017-05-19 14:00 +0200
      Re: [PATCH v2 1/6] mm, page_alloc: fix more premature OOM due to race  with cpuset update Vlastimil Babka <vbabka@suse.cz> - 2017-05-23 13:40 +0200
  [PATCH v2 4/6] mm, mempolicy: simplify rebinding mempolicies when updating cpusets Vlastimil Babka <vbabka@suse.cz> - 2017-05-17 10:20 +0200
    Re: [PATCH v2 4/6] mm, mempolicy: simplify rebinding mempolicies  when updating cpusets Michal Hocko <mhocko@kernel.org> - 2017-05-23 09:20 +0200
  Re: [PATCH v2 0/6] cpuset/mempolicies related fixes and cleanups Michal Hocko <mhocko@kernel.org> - 2017-05-17 18:30 +0200

csiph-web