Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1643445

Re: [PATCH v2 2/6] mm, mempolicy: stop adjusting current->il_next in mpol_rebind_nodemask()

From Christoph Lameter <cl@linux.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 2/6] mm, mempolicy: stop adjusting current->il_next in mpol_rebind_nodemask()
Date 2017-05-17 17:10 +0200
Message-ID <tI8Km-4GH-17@gated-at.bofh.it> (permalink)
References <tI2lA-AO-13@gated-at.bofh.it> <tI2lA-AO-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, 17 May 2017, Vlastimil Babka wrote:

> The task->il_next variable stores the next allocation node id for task's
> MPOL_INTERLEAVE policy. mpol_rebind_nodemask() updates interleave and
> bind mempolicies due to changing cpuset mems. Currently it also tries to
> make sure that current->il_next is valid within the updated nodemask. This is
> bogus, because 1) we are updating potentially any task's mempolicy, not just
> current, and 2) we might be updating a per-vma mempolicy, not task one.

Reviewed-by: Christoph Lameter <cl@linux.com>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/6] cpuset/mempolicies related fixes and cleanups Vlastimil Babka <vbabka@suse.cz> - 2017-05-17 10:20 +0200
  [PATCH v2 2/6] mm, mempolicy: stop adjusting current->il_next in mpol_rebind_nodemask() Vlastimil Babka <vbabka@suse.cz> - 2017-05-17 10:20 +0200
    Re: [PATCH v2 2/6] mm, mempolicy: stop adjusting current->il_next  in mpol_rebind_nodemask() Christoph Lameter <cl@linux.com> - 2017-05-17 17:10 +0200
  [PATCH v2 6/6] mm, mempolicy: don't check cpuset seqlock where it doesn't matter Vlastimil Babka <vbabka@suse.cz> - 2017-05-17 10:20 +0200
    Re: [PATCH v2 6/6] mm, mempolicy: don't check cpuset seqlock where  it doesn't matter Michal Hocko <mhocko@kernel.org> - 2017-05-23 09:20 +0200
  [PATCH v2 3/6] mm, page_alloc: pass preferred nid instead of zonelist to allocator Vlastimil Babka <vbabka@suse.cz> - 2017-05-17 10:20 +0200
    Re: [PATCH v2 3/6] mm, page_alloc: pass preferred nid instead of  zonelist to allocator Christoph Lameter <cl@linux.com> - 2017-05-17 17:20 +0200
      Re: [PATCH v2 3/6] mm, page_alloc: pass preferred nid instead of  zonelist to allocator Vlastimil Babka <vbabka@suse.cz> - 2017-05-18 12:30 +0200
    Re: [PATCH v2 3/6] mm, page_alloc: pass preferred nid instead of  zonelist to allocator Michal Hocko <mhocko@kernel.org> - 2017-05-19 14:00 +0200
  [PATCH v2 1/6] mm, page_alloc: fix more premature OOM due to race with cpuset update Vlastimil Babka <vbabka@suse.cz> - 2017-05-17 10:20 +0200
    Re: [PATCH v2 1/6] mm, page_alloc: fix more premature OOM due to  race with cpuset update Michal Hocko <mhocko@kernel.org> - 2017-05-19 14:00 +0200
      Re: [PATCH v2 1/6] mm, page_alloc: fix more premature OOM due to race  with cpuset update Vlastimil Babka <vbabka@suse.cz> - 2017-05-23 13:40 +0200
  [PATCH v2 4/6] mm, mempolicy: simplify rebinding mempolicies when updating cpusets Vlastimil Babka <vbabka@suse.cz> - 2017-05-17 10:20 +0200
    Re: [PATCH v2 4/6] mm, mempolicy: simplify rebinding mempolicies  when updating cpusets Michal Hocko <mhocko@kernel.org> - 2017-05-23 09:20 +0200
  Re: [PATCH v2 0/6] cpuset/mempolicies related fixes and cleanups Michal Hocko <mhocko@kernel.org> - 2017-05-17 18:30 +0200

csiph-web