Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1641948

Re: [PATCH] ubifs: Fix inode leak in xattr code

Show all headers | View raw

Artem,

Am 15.05.2017 um 18:05 schrieb Artem Bityutskiy:
> On Mon, 2017-05-15 at 17:22 +0200, Richard Weinberger wrote:
>> Alternatively we could add a iget_locked/drop_nlink/iput sequence to
>> ubifs_tnc_remove_ino(). But that will make unlink() much slower for
>> files
>> that contain xattrs.
> 
> At that level we'd need to do it for every xattr, even those that were
> never be accessed, which would be slow indeed.
> 
> But we really only need to check the inode cache: hey, icache, I am
> dying, and if you have any of my guys (xattrs), I want them to die with
> me. 
> 
> So the question is how to find our guys in the inode cache. I am not
> sure. Probably be we'd have to have our own list of cached inodes in
> the host inode, and maintain it.

BTW: Do you happen to know how other filesystems cache xattrs?
If they actually do.

Thanks,
//richard

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ubifs: Fix inode leak in xattr code Richard Weinberger <richard@nod.at> - 2017-05-15 16:30 +0200
  Re: [PATCH] ubifs: Fix inode leak in xattr code Artem Bityutskiy <dedekind1@gmail.com> - 2017-05-15 17:00 +0200
    Re: [PATCH] ubifs: Fix inode leak in xattr code Richard Weinberger <richard@nod.at> - 2017-05-15 17:30 +0200
      Re: [PATCH] ubifs: Fix inode leak in xattr code Artem Bityutskiy <dedekind1@gmail.com> - 2017-05-15 18:10 +0200
        Re: [PATCH] ubifs: Fix inode leak in xattr code Richard Weinberger <richard@nod.at> - 2017-05-15 18:30 +0200
        Re: [PATCH] ubifs: Fix inode leak in xattr code Richard Weinberger <richard@nod.at> - 2017-05-15 20:00 +0200
        Re: [PATCH] ubifs: Fix inode leak in xattr code Richard Weinberger <richard@nod.at> - 2017-05-17 00:30 +0200

csiph-web