Re: [PATCH] ubifs: Fix inode leak in xattr code

From	Richard Weinberger <richard@nod.at>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ubifs: Fix inode leak in xattr code
Date	2017-05-17 00:30 +0200
Message-ID	<tHT8C-3a6-19@gated-at.bofh.it> (permalink)
References	<tHpaz-Ra-45@gated-at.bofh.it> <tHpDz-12A-15@gated-at.bofh.it> <tHq6C-1u3-17@gated-at.bofh.it> <tHqJj-1Wb-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Artem,

Am 15.05.2017 um 18:05 schrieb Artem Bityutskiy:
> On Mon, 2017-05-15 at 17:22 +0200, Richard Weinberger wrote:
>> Alternatively we could add a iget_locked/drop_nlink/iput sequence to
>> ubifs_tnc_remove_ino(). But that will make unlink() much slower for
>> files
>> that contain xattrs.
> 
> At that level we'd need to do it for every xattr, even those that were
> never be accessed, which would be slow indeed.
> 
> But we really only need to check the inode cache: hey, icache, I am
> dying, and if you have any of my guys (xattrs), I want them to die with
> me. 

That turned out to be much easier than expected.
Patch ahead!

Thanks,
//richard

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ubifs: Fix inode leak in xattr code Richard Weinberger <richard@nod.at> - 2017-05-15 16:30 +0200
  Re: [PATCH] ubifs: Fix inode leak in xattr code Artem Bityutskiy <dedekind1@gmail.com> - 2017-05-15 17:00 +0200
    Re: [PATCH] ubifs: Fix inode leak in xattr code Richard Weinberger <richard@nod.at> - 2017-05-15 17:30 +0200
      Re: [PATCH] ubifs: Fix inode leak in xattr code Artem Bityutskiy <dedekind1@gmail.com> - 2017-05-15 18:10 +0200
        Re: [PATCH] ubifs: Fix inode leak in xattr code Richard Weinberger <richard@nod.at> - 2017-05-15 18:30 +0200
        Re: [PATCH] ubifs: Fix inode leak in xattr code Richard Weinberger <richard@nod.at> - 2017-05-15 20:00 +0200
        Re: [PATCH] ubifs: Fix inode leak in xattr code Richard Weinberger <richard@nod.at> - 2017-05-17 00:30 +0200

csiph-web