Re: [RFC v1 2/3] interconnect: Add Qualcomm msm8916 interconnect provider driver

From	Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups	linux.kernel
Subject	Re: [RFC v1 2/3] interconnect: Add Qualcomm msm8916 interconnect provider driver
Date	2017-05-15 18:10 +0200
Message-ID	<tHqJj-1Wb-1@gated-at.bofh.it> (permalink)
References	<tHqgh-1xf-5@gated-at.bofh.it> <tHqgh-1xf-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Georgi,

On Mon, May 15, 2017 at 5:35 PM, Georgi Djakov <georgi.djakov@linaro.org> wrote:
> --- /dev/null
> +++ b/drivers/interconnect/qcom/interconnect_msm8916.c

> +struct qcom_interconnect_node {
> +       struct interconnect_node node;
> +       unsigned int id;

4 byte gap due to alignment rules on 64-bit.

> +       unsigned char *name;
> +       struct interconnect_node *links[8];
> +       int num_links;
> +       int port;
> +       int buswidth;

4 byte gap due to alignment rules.

> +       u64 ib;
> +       u64 ab;
> +       u64 rate;
> +};

You can avoid the gaps by putting members of the same size and alignment
together.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Thread

[RFC v1 2/3] interconnect: Add Qualcomm msm8916 interconnect provider driver Georgi Djakov <georgi.djakov@linaro.org> - 2017-05-15 17:40 +0200
  Re: [RFC v1 2/3] interconnect: Add Qualcomm msm8916 interconnect  provider driver Geert Uytterhoeven <geert@linux-m68k.org> - 2017-05-15 18:10 +0200
    Re: [RFC v1 2/3] interconnect: Add Qualcomm msm8916 interconnect  provider driver Georgi Djakov <georgi.djakov@linaro.org> - 2017-05-16 17:00 +0200

csiph-web