Re: [RFC v1 2/3] interconnect: Add Qualcomm msm8916 interconnect provider driver

From	Georgi Djakov <georgi.djakov@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [RFC v1 2/3] interconnect: Add Qualcomm msm8916 interconnect provider driver
Date	2017-05-16 17:00 +0200
Message-ID	<tHM78-6TZ-7@gated-at.bofh.it> (permalink)
References	<tHqgh-1xf-5@gated-at.bofh.it> <tHqgh-1xf-3@gated-at.bofh.it> <tHqJj-1Wb-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 05/15/2017 07:01 PM, Geert Uytterhoeven wrote:
> Hi Georgi,
> 
> On Mon, May 15, 2017 at 5:35 PM, Georgi Djakov <georgi.djakov@linaro.org> wrote:
>> --- /dev/null
>> +++ b/drivers/interconnect/qcom/interconnect_msm8916.c
> 
>> +struct qcom_interconnect_node {
>> +       struct interconnect_node node;
>> +       unsigned int id;
> 
> 4 byte gap due to alignment rules on 64-bit.
> 
>> +       unsigned char *name;
>> +       struct interconnect_node *links[8];
>> +       int num_links;
>> +       int port;
>> +       int buswidth;
> 
> 4 byte gap due to alignment rules.
> 
>> +       u64 ib;
>> +       u64 ab;
>> +       u64 rate;
>> +};
> 
> You can avoid the gaps by putting members of the same size and alignment
> together.

Thanks Geert, i will rearrange this to reduce the padding bytes!

BR,
Georgi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC v1 2/3] interconnect: Add Qualcomm msm8916 interconnect provider driver Georgi Djakov <georgi.djakov@linaro.org> - 2017-05-15 17:40 +0200
  Re: [RFC v1 2/3] interconnect: Add Qualcomm msm8916 interconnect  provider driver Geert Uytterhoeven <geert@linux-m68k.org> - 2017-05-15 18:10 +0200
    Re: [RFC v1 2/3] interconnect: Add Qualcomm msm8916 interconnect  provider driver Georgi Djakov <georgi.djakov@linaro.org> - 2017-05-16 17:00 +0200

csiph-web