Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1641746

Re: [PATCH V2] x86/efi: Add EFI_PGT_DUMP support for x86_32, kexec

Path csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From Matt Fleming <matt@codeblueprint.co.uk>
Newsgroups linux.kernel
Subject Re: [PATCH V2] x86/efi: Add EFI_PGT_DUMP support for x86_32, kexec
Date Mon, 15 May 2017 16:30:03 +0200
Message-ID <tHpaz-Ra-29@gated-at.bofh.it> (permalink)
References <tG1WG-20E-13@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeblueprint-co-uk.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Q1O7+li287ZQNkRn4LHcy1+dpxTHTjQ5mjmnDXhC9VA=; b=fK9tOPtiLvbTBCKVlC6k6RBtTJhT8OAKa4lecqx9QEW3026J76N7SGBhjjJ9T55IMy 423lF0Rd6YoIb2qtoXVLx5kdn0l+9phDMyLF25zjtaK5VgEcRCFQhhy8yEc69vODgxk4 3tBhAq+6MnuQL2wnRVyS8+aRsjawLT0qoxxlkwUfLlvpZw2/BV4qEXJ2T9ez08sw5yRu lvYndihD/hSynjXXggdrtoj7mOl/n+ZrIE5wOC80kFx+35GsHkvobR0XBE13sFby1hzM RFG90hrkfLLWL3X0CmxzgbtE/gyrURVtKqmkQbR7gKFA12D7jYFeMTw/5xLfsiCRaiAg Dm8Q==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Q1O7+li287ZQNkRn4LHcy1+dpxTHTjQ5mjmnDXhC9VA=; b=OETYNSrSpPA0jcIWt8oSV0RzlD3BOiaTyKi1sdfJXHt/zdZOFKhQMaJKbqRA7rbzw/ 0xkDSiYO5dPlidPYG3bgndlKtqcsFsyznPu/w77VrG5ZbyJc6E1VJiElnb5LFbtvs8iv K6xOBBxuCvVume0CCOYNQszqdagGm91Kdke3JdEMPkVl7vO786BeZblZdW5OvLq1PhpT JYMu8h+/DzU8MAG3bVgs6WNgWAjXxP19DvSz6jAlMZLbfyqUU0C1JlieL8julMj6nJlJ lFP6YUuUURnbNoEjRTOG7y5y3H4zjhppsVpnA5I6t+JHsQqrnBfG6rN4dnYUiBwaMTRv /Nwg==
X-Gm-Message-State AODbwcCr8BwoDaSuyYVs43QWRfOqxHLarxBo2qwOR7srUF+ux6+7RSfH 8U03EvD4R3JoSQ==
X-Received by 10.28.173.65 with SMTP id w62mr4372409wme.48.1494858451272; Mon, 15 May 2017 07:27:31 -0700 (PDT)
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 29
Organization linux.* mail to news gateway
X-Original-Cc linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Borislav Petkov <bp@alien8.de>, Ricardo Neri <ricardo.neri@intel.com>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Ravi Shankar <ravi.v.shankar@intel.com>
X-Original-Date Mon, 15 May 2017 15:27:29 +0100
X-Original-Message-ID <20170515142729.GE2935@codeblueprint.co.uk>
X-Original-References <1494530433-19503-1-git-send-email-sai.praneeth.prakhya@intel.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1641746

Show key headers only | View raw


On Thu, 11 May, at 12:20:33PM, Sai Praneeth Prakhya wrote:
> From: Sai Praneeth <sai.praneeth.prakhya@intel.com>
> 
> EFI_PGT_DUMP, as the name suggests dumps efi page tables to dmesg during
> kernel boot. This feature is very useful while debugging page
> faults/null pointer dereferences to efi related addresses. Presently,
> this feature is limited only to x86_64, so let's extend it to other efi
> configurations like kexec kernel, efi=old_map and to x86_32 as well.
> This doesn't effect normal boot path because this config option should
> be used only for debug purposes.
> 
> Signed-off-by: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Ricardo Neri <ricardo.neri@intel.com>
> Cc: Matt Fleming <matt@codeblueprint.co.uk>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Ravi Shankar <ravi.v.shankar@intel.com>
> 
> Changes since v1:
> 1. Call efi_dump_pagetable() only once from efi_enter_virtual_mode() -
> as suggested by Boris
> 
> ---
>  arch/x86/platform/efi/efi.c    | 3 ++-
>  arch/x86/platform/efi/efi_32.c | 9 ++++++++-
>  arch/x86/platform/efi/efi_64.c | 5 ++++-
>  3 files changed, 14 insertions(+), 3 deletions(-)

Thanks Sai, applied.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH V2] x86/efi: Add EFI_PGT_DUMP support for x86_32, kexec Matt Fleming <matt@codeblueprint.co.uk> - 2017-05-15 16:30 +0200

csiph-web