Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1641746

Re: [PATCH V2] x86/efi: Add EFI_PGT_DUMP support for x86_32, kexec

From Matt Fleming <matt@codeblueprint.co.uk>
Newsgroups linux.kernel
Subject Re: [PATCH V2] x86/efi: Add EFI_PGT_DUMP support for x86_32, kexec
Date 2017-05-15 16:30 +0200
Message-ID <tHpaz-Ra-29@gated-at.bofh.it> (permalink)
References <tG1WG-20E-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, 11 May, at 12:20:33PM, Sai Praneeth Prakhya wrote:
> From: Sai Praneeth <sai.praneeth.prakhya@intel.com>
> 
> EFI_PGT_DUMP, as the name suggests dumps efi page tables to dmesg during
> kernel boot. This feature is very useful while debugging page
> faults/null pointer dereferences to efi related addresses. Presently,
> this feature is limited only to x86_64, so let's extend it to other efi
> configurations like kexec kernel, efi=old_map and to x86_32 as well.
> This doesn't effect normal boot path because this config option should
> be used only for debug purposes.
> 
> Signed-off-by: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Ricardo Neri <ricardo.neri@intel.com>
> Cc: Matt Fleming <matt@codeblueprint.co.uk>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Ravi Shankar <ravi.v.shankar@intel.com>
> 
> Changes since v1:
> 1. Call efi_dump_pagetable() only once from efi_enter_virtual_mode() -
> as suggested by Boris
> 
> ---
>  arch/x86/platform/efi/efi.c    | 3 ++-
>  arch/x86/platform/efi/efi_32.c | 9 ++++++++-
>  arch/x86/platform/efi/efi_64.c | 5 ++++-
>  3 files changed, 14 insertions(+), 3 deletions(-)

Thanks Sai, applied.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH V2] x86/efi: Add EFI_PGT_DUMP support for x86_32, kexec Matt Fleming <matt@codeblueprint.co.uk> - 2017-05-15 16:30 +0200

csiph-web