Re: [PATCH 1/2] dax: hide block device code in #ifdef

Path	csiph.com!news.freedyn.net!open-news-network.org!aioe.org!bofh.it!news.nic.it!robomod
From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] dax: hide block device code in #ifdef
Date	Mon, 15 May 2017 16:30:02 +0200
Message-ID	<tHpay-Ra-5@gated-at.bofh.it> (permalink)
References	<tHoxP-pi-3@gated-at.bofh.it> <tHp0R-O3-7@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=ATybit9pml0dlC1Xr6p5BkpFp612kGcVMOENMjTLSaQ=; b=e1oB0anG0QjW6E6a7uyrNCFc7xIJN9ERDWfaJxnSw4fSiEXgd2N+fOsteVP+H5ntAk EGkpHgR9cSr2SnXJSUtwf1Fb+On0ioIGEgMVmVjCBI6peGjplAxALnH5ExvoevhnbYrh nms/pqdKaPK5f58lK+e/5aB6FiOIRSnux7i+rlibyaftpzni0pDKKhuXR+6ib8Vt4jEs KtomAOFKMzTHSpE688h7asDC87wCMb2OUNjYN7l4m5g0GxhvkqHfIis2p0Bd7X+RV9cc 2nKZPj+Vs9u+zfi2xfFIVtaVxGgzdvPvFrwJj2z0l9D8lAwq5CIqwi8vM5TEijYKPvHr Ff7g==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=ATybit9pml0dlC1Xr6p5BkpFp612kGcVMOENMjTLSaQ=; b=jFbMWgq3WklKm+x0KTRXw1uqoULh4/XqNxIImUxHYVRh4PVjDHkR8gYfhQ/BGKGCtV AdWsgvOjjRlRnd2+luU2BxRKSKwSQKYq4n61IFM4dnWjFTbX8AEDDjZUel8YaxIRoRAN 8ahg7LYq70Soy81CcrXAmhMebbj95ns3N+8h/bUIh8TFYu2OpmbNk8vcfhenAJRuDSTJ IUJH311xNeawuWBhBwgfd9EaW2IUibceGMnMpgTuQu/Ecga+AWVSZCSSI4teWZZYGeqo OpE7V1DxoZ+DV4TeC1W6mrKVZ2HyU1ATWyetVFVjA47S4go/TfNS3y0Eo7Ef/lSwGSbA lMbQ==
X-Gm-Message-State	AODbwcCnUCurpgwAoFjALgmIDrFnCvYRwpi2XeQK1PXXHO4z4Xfif6aZ dqVrOolw7d0A3WObTW4hKssq6iCKwg==
X-Received	by 10.202.72.17 with SMTP id v17mr3037972oia.78.1494858010180; Mon, 15 May 2017 07:20:10 -0700 (PDT)
MIME-Version	1.0
X-Google-Sender-Auth	t4HYxuv_C37HGxunHRsQLCiwVNI
Content-Type	text/plain; charset="UTF-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	28
Organization	linux.* mail to news gateway
X-Original-Cc	Jan Kara <jack@suse.com>, Geert Uytterhoeven <geert@linux-m68k.org>, linux-xfs@vger.kernel.org, "Darrick J . Wong" <darrick.wong@oracle.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date	Mon, 15 May 2017 16:20:09 +0200
X-Original-Message-ID	<CAK8P3a1XU32oVTeV5=TeV8C+66rKKoRJnebQTAzqUr1BcSH69w@mail.gmail.com>
X-Original-References	<20170515134508.2713243-1-arnd@arndb.de> <CAPcyv4jxondHhtMZbr01XE+w1Q0mxy+mR=4ypwsHpA0AtJuj2g@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1641739

Show key headers only | View raw

On Mon, May 15, 2017 at 4:11 PM, Dan Williams <dan.j.williams@intel.com> wrote:
> On Mon, May 15, 2017 at 6:44 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> We allow configurations with CONFIG_BLOCK=n and CONFIG_DAX=y, which now
>> results in a link error:
>>
>> drivers/dax/super.c: In function 'bdev_dax_pgoff':
>> drivers/dax/super.c:50:26: error: implicit declaration of function 'get_start_sect'; did you mean 'get_task_cred'? [-Werror=implicit-function-declaration]
>>
>> The two obvious ways to avoid the link error are to either add an #ifdef
>> around the code that was moved from fs/block_dev.c, or to disallow the
>> configuration. I could not see if there is or is not a reason to support
>> this combination of options, but in case there is, the #ifdef is the
>> safer choice.
>>
>> Fixes: ef51042472f5 ("block, dax: move "select DAX" from BLOCK to FS_DAX")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Yup, the same one I came up with:
>
> https://patchwork.kernel.org/patch/9725513/
>
> If you have a a pull request coming up soon you can add my Acked-by to
> both of these patches, otherwise I'll send what I have along at the
> end of the week.

I didn't plan to send a pull request, please use whatever you have.

      Arnd

Thread

[PATCH 1/2] dax: hide block device code in #ifdef Arnd Bergmann <arnd@arndb.de> - 2017-05-15 15:50 +0200
  [PATCH 2/2] fs: xfs: add DAX dependency Arnd Bergmann <arnd@arndb.de> - 2017-05-15 15:50 +0200
  Re: [PATCH 1/2] dax: hide block device code in #ifdef Dan Williams <dan.j.williams@intel.com> - 2017-05-15 16:20 +0200
    Re: [PATCH 1/2] dax: hide block device code in #ifdef Arnd Bergmann <arnd@arndb.de> - 2017-05-15 16:30 +0200
      Re: [PATCH 1/2] dax: hide block device code in #ifdef "Darrick J. Wong" <darrick.wong@oracle.com> - 2017-05-15 18:00 +0200
        Re: [PATCH 1/2] dax: hide block device code in #ifdef Arnd Bergmann <arnd@arndb.de> - 2017-05-16 13:20 +0200

csiph-web