Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1641739

Re: [PATCH 1/2] dax: hide block device code in #ifdef

Show all headers | View raw

On Mon, May 15, 2017 at 4:11 PM, Dan Williams <dan.j.williams@intel.com> wrote:
> On Mon, May 15, 2017 at 6:44 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> We allow configurations with CONFIG_BLOCK=n and CONFIG_DAX=y, which now
>> results in a link error:
>>
>> drivers/dax/super.c: In function 'bdev_dax_pgoff':
>> drivers/dax/super.c:50:26: error: implicit declaration of function 'get_start_sect'; did you mean 'get_task_cred'? [-Werror=implicit-function-declaration]
>>
>> The two obvious ways to avoid the link error are to either add an #ifdef
>> around the code that was moved from fs/block_dev.c, or to disallow the
>> configuration. I could not see if there is or is not a reason to support
>> this combination of options, but in case there is, the #ifdef is the
>> safer choice.
>>
>> Fixes: ef51042472f5 ("block, dax: move "select DAX" from BLOCK to FS_DAX")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Yup, the same one I came up with:
>
> https://patchwork.kernel.org/patch/9725513/
>
> If you have a a pull request coming up soon you can add my Acked-by to
> both of these patches, otherwise I'll send what I have along at the
> end of the week.

I didn't plan to send a pull request, please use whatever you have.

      Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] dax: hide block device code in #ifdef Arnd Bergmann <arnd@arndb.de> - 2017-05-15 15:50 +0200
  [PATCH 2/2] fs: xfs: add DAX dependency Arnd Bergmann <arnd@arndb.de> - 2017-05-15 15:50 +0200
  Re: [PATCH 1/2] dax: hide block device code in #ifdef Dan Williams <dan.j.williams@intel.com> - 2017-05-15 16:20 +0200
    Re: [PATCH 1/2] dax: hide block device code in #ifdef Arnd Bergmann <arnd@arndb.de> - 2017-05-15 16:30 +0200
      Re: [PATCH 1/2] dax: hide block device code in #ifdef "Darrick J. Wong" <darrick.wong@oracle.com> - 2017-05-15 18:00 +0200
        Re: [PATCH 1/2] dax: hide block device code in #ifdef Arnd Bergmann <arnd@arndb.de> - 2017-05-16 13:20 +0200

csiph-web