Re: [patch 07/18] ACPI: Adjust system_state check

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [patch 07/18] ACPI: Adjust system_state check
Date	Mon, 15 May 2017 16:30:02 +0200
Message-ID	<tHpay-Ra-3@gated-at.bofh.it> (permalink)
References	<tH6AV-56V-3@gated-at.bofh.it> <tH6AW-56V-13@gated-at.bofh.it>
Dmarc-Filter	OpenDMARC Filter v1.3.2 mail.kernel.org 878F7239BC
Authentication-Results	mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org
Authentication-Results	mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org
X-Mailer	Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	45
Organization	linux.* mail to news gateway
X-Original-Cc	LKML <linux-kernel@vger.kernel.org>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, linux-acpi@vger.kernel.org, Len Brown <lenb@kernel.org>
X-Original-Date	Mon, 15 May 2017 10:27:00 -0400
X-Original-Message-ID	<20170515102700.0037d156@gandalf.local.home>
X-Original-References	<20170514182716.347236777@linutronix.de> <20170514183613.002084749@linutronix.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1641738

Show key headers only | View raw

[ added linux-acpi and took off arm list ;-) ]

On Sun, 14 May 2017 20:27:23 +0200
Thomas Gleixner <tglx@linutronix.de> wrote:

> To enable smp_processor_id() and might_sleep() debug checks earlier, it's
> required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING.
> 
> Make the decision wether a pci root is hotplugged depend on SYSTEM_RUNNING
> instead of !SYSTEM_BOOTING.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: linux-arm-kernel@lists.infradead.org
> ---
>  drivers/acpi/pci_root.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/acpi/pci_root.c
> +++ b/drivers/acpi/pci_root.c
> @@ -523,7 +523,7 @@ static int acpi_pci_root_add(struct acpi
>  	struct acpi_pci_root *root;
>  	acpi_handle handle = device->handle;
>  	int no_aspm = 0;
> -	bool hotadd = system_state != SYSTEM_BOOTING;
> +	bool hotadd = system_state == SYSTEM_RUNNING;

What about the other boot states greater than SYSTEM_RUNNING? Can this
be called then too?

IOW, should it be:

	bool hotadd = system_state >= SYSTEM_RUNNING;

?

-- Steve

>  
>  	root = kzalloc(sizeof(struct acpi_pci_root), GFP_KERNEL);
>  	if (!root)
>

Thread

[patch 07/18] ACPI: Adjust system_state check Thomas Gleixner <tglx@linutronix.de> - 2017-05-14 20:40 +0200
  Re: [patch 07/18] ACPI: Adjust system_state check Thomas Gleixner <tglx@linutronix.de> - 2017-05-15 12:30 +0200
  Re: [patch 07/18] ACPI: Adjust system_state check Mark Rutland <mark.rutland@arm.com> - 2017-05-15 12:30 +0200
  Re: [patch 07/18] ACPI: Adjust system_state check Steven Rostedt <rostedt@goodmis.org> - 2017-05-15 16:30 +0200
    Re: [patch 07/18] ACPI: Adjust system_state check Thomas Gleixner <tglx@linutronix.de> - 2017-05-16 20:20 +0200

csiph-web