Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1642402

Re: [PATCH v2 04/11] arm64: dts: Initial DTS files for Broadcom Stingray SOC

Show all headers | View raw

On Mon, May 15, 2017 at 6:43 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> Hi,
>
> On Mon, May 15, 2017 at 05:32:14PM +0530, Anup Patel wrote:
>> +/ {
>> +     chosen { /* Default kernel args */
>> +             bootargs = "root=/dev/ram rw rootwait \
>> +                         earlycon=uart8250,mmio32,0x68a10000 \
>> +                         pci=pcie_bus_safe cma=64M";
>
> Why do we need all of these?

Yes, we don't need bootargs here. This were just for reference.

I will remove default bootargs because its responsibility of
bootloader to add it.

>
>> +             linux,stdout-path = "serial0:115200n8";
>
> Please drop the 'linux,' prefix here.

Sure, will do.

>
> [...]
>
>> +     memory: memory@80000000 {
>> +             device_type = "memory";
>> +             reg = <0x00000000 0x80000000 0 0x40000000>;
>> +     };
>> +
>> +     psci {
>> +             compatible = "arm,psci-0.2";
>> +             method = "smc";
>> +     };
>> +
>> +     pmu {
>> +             compatible = "arm,armv8-pmuv3";
>> +             interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
>> +     };
>> +
>> +     timer {
>> +             compatible = "arm,armv8-timer";
>> +             interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) |
>> +                           IRQ_TYPE_LEVEL_LOW)>,
>> +                          <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) |
>> +                           IRQ_TYPE_LEVEL_LOW)>,
>> +                          <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) |
>> +                           IRQ_TYPE_LEVEL_LOW)>,
>> +                          <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) |
>> +                           IRQ_TYPE_LEVEL_LOW)>;
>
> GICv3 PPIs don't have a mask. See
>
> Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt
>
> Please remove the GIC_CPU_MASK_*() uses here and in this dts. They
> shouldn't be there.

Thanks for catching.

We had taken care of this in PMU DT node but did not cleanup timer
DT node.

Thanks,
Anup

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/11] Broadcom Stingray SOC Initial Support Anup Patel <anup.patel@broadcom.com> - 2017-05-15 14:10 +0200
  [PATCH v2 07/11] arm64: dts: Add pinctrl DT nodes for Stingray SOC Anup Patel <anup.patel@broadcom.com> - 2017-05-15 14:10 +0200
  [PATCH v2 09/11] arm64: dts: Add I2C DT nodes for Stingray SoC Anup Patel <anup.patel@broadcom.com> - 2017-05-15 14:10 +0200
  [PATCH v2 08/11] arm64: dts: Add GPIO DT nodes for Stingray SOC Anup Patel <anup.patel@broadcom.com> - 2017-05-15 14:10 +0200
  [PATCH v2 02/11] dt-bindings: clk: Extend binding doc for Stingray SOC Anup Patel <anup.patel@broadcom.com> - 2017-05-15 14:10 +0200
  [PATCH v2 04/11] arm64: dts: Initial DTS files for Broadcom Stingray SOC Anup Patel <anup.patel@broadcom.com> - 2017-05-15 14:10 +0200
    Re: [PATCH v2 04/11] arm64: dts: Initial DTS files for Broadcom  Stingray SOC Mark Rutland <mark.rutland@arm.com> - 2017-05-15 15:20 +0200
      Re: [PATCH v2 04/11] arm64: dts: Initial DTS files for Broadcom  Stingray SOC Scott Branden <scott.branden@broadcom.com> - 2017-05-15 18:10 +0200
      Re: [PATCH v2 04/11] arm64: dts: Initial DTS files for Broadcom  Stingray SOC Anup Patel <anup.patel@broadcom.com> - 2017-05-16 12:50 +0200
  [PATCH v2 03/11] clk: bcm: Add clocks for Stingray SOC Anup Patel <anup.patel@broadcom.com> - 2017-05-15 14:10 +0200
  [PATCH v2 05/11] arm64: dts: Add clock DT nodes for Stingray SOC Anup Patel <anup.patel@broadcom.com> - 2017-05-15 14:10 +0200
  [PATCH v2 10/11] arm64: dts: Add PL022, PL330 and SP805 DT nodes for Stingray Anup Patel <anup.patel@broadcom.com> - 2017-05-15 14:10 +0200
  [PATCH v2 01/11] dt-bindings: bcm: Add Broadcom Stingray bindings document Anup Patel <anup.patel@broadcom.com> - 2017-05-15 14:10 +0200

csiph-web