Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1642362

Re: [PATCH] drm: use kvmalloc_array for drm_malloc*

From Chris Wilson <chris@chris-wilson.co.uk>
Newsgroups linux.kernel
Subject Re: [PATCH] drm: use kvmalloc_array for drm_malloc*
Date 2017-05-16 11:40 +0200
Message-ID <tHH7s-3Qc-17@gated-at.bofh.it> (permalink)
References <tHGEq-3GY-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, May 16, 2017 at 11:06:06AM +0200, Michal Hocko wrote:
> From: Michal Hocko <mhocko@suse.com>
> 
> drm_malloc* has grown their own kmalloc with vmalloc fallback
> implementations. MM has grown kvmalloc* helpers in the meantime. Let's
> use those because it a) reduces the code and b) MM has a better idea
> how to implement fallbacks (e.g. do not vmalloc before kmalloc is tried
> with __GFP_NORETRY).

Better? The same idea. The only difference I was reluctant to hand out
large pages for long lived objects. If that's the wisdom of the core mm,
so be it.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm: use kvmalloc_array for drm_malloc* Michal Hocko <mhocko@kernel.org> - 2017-05-16 11:10 +0200
  Re: [PATCH] drm: use kvmalloc_array for drm_malloc* Daniel Vetter <daniel@ffwll.ch> - 2017-05-16 11:30 +0200
    Re: [PATCH] drm: use kvmalloc_array for drm_malloc* Michal Hocko <mhocko@kernel.org> - 2017-05-16 12:00 +0200
      Re: [PATCH] drm: use kvmalloc_array for drm_malloc* Michal Hocko <mhocko@kernel.org> - 2017-05-16 15:30 +0200
  Re: [PATCH] drm: use kvmalloc_array for drm_malloc* Chris Wilson <chris@chris-wilson.co.uk> - 2017-05-16 11:40 +0200
    Re: [PATCH] drm: use kvmalloc_array for drm_malloc* Michal Hocko <mhocko@kernel.org> - 2017-05-16 13:00 +0200
      Re: [PATCH] drm: use kvmalloc_array for drm_malloc* Chris Wilson <chris@chris-wilson.co.uk> - 2017-05-16 13:10 +0200
        Re: [PATCH] drm: use kvmalloc_array for drm_malloc* Michal Hocko <mhocko@kernel.org> - 2017-05-17 09:50 +0200
          Re: [PATCH] drm: use kvmalloc_array for drm_malloc* Chris Wilson <chris@chris-wilson.co.uk> - 2017-05-17 10:10 +0200
            Re: [PATCH] drm: use kvmalloc_array for drm_malloc* Michal Hocko <mhocko@kernel.org> - 2017-05-17 10:20 +0200

csiph-web