Re: [PATCH v3] drivers/staging: refactor dgnc tty registration.

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] drivers/staging: refactor dgnc tty registration.
Date	2017-05-16 10:00 +0200
Message-ID	<tHFyG-2LQ-5@gated-at.bofh.it> (permalink)
References	<tHmPn-7IC-1@gated-at.bofh.it> <tHns5-8dX-5@gated-at.bofh.it> <tHnLs-8lN-17@gated-at.bofh.it> <tHoxP-pi-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, May 15, 2017 at 04:49:16PM +0300, Haim Daniel wrote:
> me@haim-toshiba1 ~ $ dpkg -l sparse
> Desired=Unknown/Install/Remove/Purge/Hold
> |
> Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
> |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
> ||/ Name              Version       Architecture  Description
> +++-=================-=============-=============-========================================
> ii  sparse            0.4.5~rc1-1   amd64         semantic parser of source
> files
> 
> me@haim-toshiba1 linux (next-20170512) $ make clean M=drivers/staging
> /dgnc/; make C=1 M=drivers/staging/dgnc/
> 
> drivers/staging/dgnc/dgnc_tty.c:66:25: warning: too long initializer-string
> for array of char
> 

I downloaded the latest Sparse and don't see that warning.  But GCC has
a warning like that so I think this is really a GCC warning.  It doesn't
trigger for me, and with my config it's in fact, not a bug.  The buffer
is 19 characters and INIT_C_CC is 17 chars plus 1 NUL terminator.

All these things are generic termios defines so I'm not even sure how
you're triggering the warning.

Anyway, your patch is harmless enough.

regards,
dan carpenter

Thread

[PATCH] drivers/staging: refactor dgnc tty registration. Haim Daniel <haimdaniel@gmail.com> - 2017-05-14 18:00 +0200
  Re: [PATCH] drivers/staging: refactor dgnc tty registration. Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-15 10:50 +0200
    [PATCH v2] drivers/staging: refactor dgnc tty registration. Haim Daniel <haimdaniel@gmail.com> - 2017-05-15 13:50 +0200
      Re: [PATCH v2] drivers/staging: refactor dgnc tty registration. Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-15 14:00 +0200
        [PATCH v3] drivers/staging: refactor dgnc tty registration. Haim Daniel <haimdaniel@gmail.com> - 2017-05-15 14:40 +0200
          Re: [PATCH v3] drivers/staging: refactor dgnc tty registration. Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-15 15:00 +0200
            Re: [PATCH v3] drivers/staging: refactor dgnc tty registration. Haim Daniel <haimdaniel@gmail.com> - 2017-05-15 15:50 +0200
              Re: [PATCH v3] drivers/staging: refactor dgnc tty registration. Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-16 10:00 +0200
            [PATCH v4] drivers/staging: refactor dgnc tty registration. Haim Daniel <haimdaniel@gmail.com> - 2017-05-15 16:20 +0200
              Re: [PATCH v4] drivers/staging: refactor dgnc tty registration. Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-16 10:00 +0200

csiph-web