Re: [PATCH v4] drivers/staging: refactor dgnc tty registration.

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4] drivers/staging: refactor dgnc tty registration.
Date	2017-05-16 10:00 +0200
Message-ID	<tHFyG-2LQ-19@gated-at.bofh.it> (permalink)
References	<tHnLs-8lN-17@gated-at.bofh.it> <tHp0R-O3-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, May 15, 2017 at 05:10:18PM +0300, Haim Daniel wrote:
> -remove duplicate tty allocation code for serial and printer drivers.
> -add missing tty c_ispeed and c_ospeed initialization to 9600.
> -fix sparse warning: too long initializer-string for array of char.

This is a GCC warning and not a Sparse warning.  I still have no idea
how it's getting triggered.  But otherwise I have reviewed the patch and
it's a nice clean up.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drivers/staging: refactor dgnc tty registration. Haim Daniel <haimdaniel@gmail.com> - 2017-05-14 18:00 +0200
  Re: [PATCH] drivers/staging: refactor dgnc tty registration. Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-15 10:50 +0200
    [PATCH v2] drivers/staging: refactor dgnc tty registration. Haim Daniel <haimdaniel@gmail.com> - 2017-05-15 13:50 +0200
      Re: [PATCH v2] drivers/staging: refactor dgnc tty registration. Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-15 14:00 +0200
        [PATCH v3] drivers/staging: refactor dgnc tty registration. Haim Daniel <haimdaniel@gmail.com> - 2017-05-15 14:40 +0200
          Re: [PATCH v3] drivers/staging: refactor dgnc tty registration. Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-15 15:00 +0200
            Re: [PATCH v3] drivers/staging: refactor dgnc tty registration. Haim Daniel <haimdaniel@gmail.com> - 2017-05-15 15:50 +0200
              Re: [PATCH v3] drivers/staging: refactor dgnc tty registration. Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-16 10:00 +0200
            [PATCH v4] drivers/staging: refactor dgnc tty registration. Haim Daniel <haimdaniel@gmail.com> - 2017-05-15 16:20 +0200
              Re: [PATCH v4] drivers/staging: refactor dgnc tty registration. Dan Carpenter <dan.carpenter@oracle.com> - 2017-05-16 10:00 +0200

csiph-web