Re: [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and secondary isr handler's

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Baruch Siach <baruch@tkos.co.il>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and secondary isr handler's
Date	Tue, 16 May 2017 08:10:01 +0200
Message-ID	<tHDQd-1Wi-1@gated-at.bofh.it> (permalink)
References	<tHDGx-1Df-1@gated-at.bofh.it> <tHDQd-1Wi-3@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	NeoMutt/20170113 (1.7.2)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	43
Organization	linux.* mail to news gateway
X-Original-Cc	Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>, Lars-Peter Clausen <lars@metafoo.de>, Scott Branden <sbranden@broadcom.com>, linux-iio@vger.kernel.org, Ray Jui <rjui@broadcom.com>, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Pavel Roskin <plroskin@gmail.com>, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, Peter Meerwald-Stadler <pmeerw@pmeerw.net>, Hartmut Knaack <knaack.h@gmx.de>, Jonathan Cameron <jic23@kernel.org>
X-Original-Date	Tue, 16 May 2017 09:08:27 +0300
X-Original-Message-ID	<20170516060826.wnw3mpq5makpnptt@sapphire.tkos.co.il>
X-Original-References	<1494913772-30904-1-git-send-email-raveendra.padasalagi@broadcom.com> <20170516060110.GA25722@kroah.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1642230

Show key headers only | View raw

Hi Greg,

On Tue, May 16, 2017 at 08:01:10AM +0200, Greg KH wrote:
> On Tue, May 16, 2017 at 11:19:32AM +0530, Raveendra Padasalagi wrote:
> > The third argument of devm_request_threaded_irq() is the primary
> > handler. It is called in hardirq context and checks whether the
> > interrupt is relevant to the device. If the primary handler returns
> > IRQ_WAKE_THREAD, the secondary handler (a.k.a. handler thread) is
> > scheduled to run in process context.
> > 
> > bcm_iproc_adc.c uses the secondary handler as the primary one
> > and the other way around. So this patch fixes the same, along with
> > re-naming the secondary handler and primary handler names properly.
> > 
> > Tested on the BCM9583XX iProc SoC based boards.
> > 
> > Reported-by: Pavel Roskin <plroskin@gmail.com>
> > Fixes: 4324c97ecedc("iio: Add driver for Broadcom iproc-static-adc")
> > Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
> > ---
> >  drivers/iio/adc/bcm_iproc_adc.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> <formletter>
> 
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.

File moved to Documentation/process/stable-kernel-rules.rst since v4.10.

Maybe linking to 
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html would 
be better.

> </formletter>

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

Thread

[RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and secondary isr handler's Raveendra Padasalagi <raveendra.padasalagi@broadcom.com> - 2017-05-16 08:00 +0200
  Re: [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and  secondary isr handler's Baruch Siach <baruch@tkos.co.il> - 2017-05-16 08:10 +0200
    Re: [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and  secondary isr handler's Greg KH <greg@kroah.com> - 2017-05-16 08:50 +0200
  Re: [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and  secondary isr handler's Greg KH <greg@kroah.com> - 2017-05-16 08:10 +0200

csiph-web