Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1642228 > unrolled thread

[RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and secondary isr handler's

Back to article view | Back to linux.kernel

Contents

  [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and secondary isr handler's Raveendra Padasalagi <raveendra.padasalagi@broadcom.com> - 2017-05-16 08:00 +0200
    Re: [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and  secondary isr handler's Baruch Siach <baruch@tkos.co.il> - 2017-05-16 08:10 +0200
      Re: [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and  secondary isr handler's Greg KH <greg@kroah.com> - 2017-05-16 08:50 +0200
    Re: [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and  secondary isr handler's Greg KH <greg@kroah.com> - 2017-05-16 08:10 +0200

#1642228 — [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and secondary isr handler's

The third argument of devm_request_threaded_irq() is the primary
handler. It is called in hardirq context and checks whether the
interrupt is relevant to the device. If the primary handler returns
IRQ_WAKE_THREAD, the secondary handler (a.k.a. handler thread) is
scheduled to run in process context.

bcm_iproc_adc.c uses the secondary handler as the primary one
and the other way around. So this patch fixes the same, along with
re-naming the secondary handler and primary handler names properly.

Tested on the BCM9583XX iProc SoC based boards.

Reported-by: Pavel Roskin <plroskin@gmail.com>
Fixes: 4324c97ecedc("iio: Add driver for Broadcom iproc-static-adc")
Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
---
 drivers/iio/adc/bcm_iproc_adc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c
index 21d38c8..7f4f9c4 100644
--- a/drivers/iio/adc/bcm_iproc_adc.c
+++ b/drivers/iio/adc/bcm_iproc_adc.c
@@ -143,7 +143,7 @@ static void iproc_adc_reg_dump(struct iio_dev *indio_dev)
 	iproc_adc_dbg_reg(dev, adc_priv, IPROC_SOFT_BYPASS_DATA);
 }
 
-static irqreturn_t iproc_adc_interrupt_handler(int irq, void *data)
+static irqreturn_t iproc_adc_interrupt_thread(int irq, void *data)
 {
 	u32 channel_intr_status;
 	u32 intr_status;
@@ -167,7 +167,7 @@ static irqreturn_t iproc_adc_interrupt_handler(int irq, void *data)
 	return IRQ_NONE;
 }
 
-static irqreturn_t iproc_adc_interrupt_thread(int irq, void *data)
+static irqreturn_t iproc_adc_interrupt_handler(int irq, void *data)
 {
 	irqreturn_t retval = IRQ_NONE;
 	struct iproc_adc_priv *adc_priv;
@@ -181,7 +181,7 @@ static irqreturn_t iproc_adc_interrupt_thread(int irq, void *data)
 	adc_priv = iio_priv(indio_dev);
 
 	regmap_read(adc_priv->regmap, IPROC_INTERRUPT_STATUS, &intr_status);
-	dev_dbg(&indio_dev->dev, "iproc_adc_interrupt_thread(),INTRPT_STS:%x\n",
+	dev_dbg(&indio_dev->dev, "iproc_adc_interrupt_handler(),INTRPT_STS:%x\n",
 			intr_status);
 
 	intr_channels = (intr_status & IPROC_ADC_INTR_MASK) >> IPROC_ADC_INTR;
@@ -566,8 +566,8 @@ static int iproc_adc_probe(struct platform_device *pdev)
 	}
 
 	ret = devm_request_threaded_irq(&pdev->dev, adc_priv->irqno,
-				iproc_adc_interrupt_thread,
 				iproc_adc_interrupt_handler,
+				iproc_adc_interrupt_thread,
 				IRQF_SHARED, "iproc-adc", indio_dev);
 	if (ret) {
 		dev_err(&pdev->dev, "request_irq error %d\n", ret);
-- 
1.9.1

[toc] | [next] | [standalone]

#1642230 — Re: [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and secondary isr handler's

Hi Greg,

On Tue, May 16, 2017 at 08:01:10AM +0200, Greg KH wrote:
> On Tue, May 16, 2017 at 11:19:32AM +0530, Raveendra Padasalagi wrote:
> > The third argument of devm_request_threaded_irq() is the primary
> > handler. It is called in hardirq context and checks whether the
> > interrupt is relevant to the device. If the primary handler returns
> > IRQ_WAKE_THREAD, the secondary handler (a.k.a. handler thread) is
> > scheduled to run in process context.
> > 
> > bcm_iproc_adc.c uses the secondary handler as the primary one
> > and the other way around. So this patch fixes the same, along with
> > re-naming the secondary handler and primary handler names properly.
> > 
> > Tested on the BCM9583XX iProc SoC based boards.
> > 
> > Reported-by: Pavel Roskin <plroskin@gmail.com>
> > Fixes: 4324c97ecedc("iio: Add driver for Broadcom iproc-static-adc")
> > Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
> > ---
> >  drivers/iio/adc/bcm_iproc_adc.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> <formletter>
> 
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.

File moved to Documentation/process/stable-kernel-rules.rst since v4.10.

Maybe linking to 
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html would 
be better.

> </formletter>

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[toc] | [prev] | [next] | [standalone]

#1642248 — Re: [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and secondary isr handler's

On Tue, May 16, 2017 at 09:08:27AM +0300, Baruch Siach wrote:
> Hi Greg,
> 
> On Tue, May 16, 2017 at 08:01:10AM +0200, Greg KH wrote:
> > On Tue, May 16, 2017 at 11:19:32AM +0530, Raveendra Padasalagi wrote:
> > > The third argument of devm_request_threaded_irq() is the primary
> > > handler. It is called in hardirq context and checks whether the
> > > interrupt is relevant to the device. If the primary handler returns
> > > IRQ_WAKE_THREAD, the secondary handler (a.k.a. handler thread) is
> > > scheduled to run in process context.
> > > 
> > > bcm_iproc_adc.c uses the secondary handler as the primary one
> > > and the other way around. So this patch fixes the same, along with
> > > re-naming the secondary handler and primary handler names properly.
> > > 
> > > Tested on the BCM9583XX iProc SoC based boards.
> > > 
> > > Reported-by: Pavel Roskin <plroskin@gmail.com>
> > > Fixes: 4324c97ecedc("iio: Add driver for Broadcom iproc-static-adc")
> > > Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
> > > ---
> > >  drivers/iio/adc/bcm_iproc_adc.c | 8 ++++----
> > >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > <formletter>
> > 
> > This is not the correct way to submit patches for inclusion in the
> > stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> > for how to do this properly.
> 
> File moved to Documentation/process/stable-kernel-rules.rst since v4.10.
> 
> Maybe linking to 
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html would 
> be better.

Ah, good point, I've updated my formletter now, thanks for this.

greg k-h

[toc] | [prev] | [next] | [standalone]

#1642231 — Re: [RESEND PATCH] iio: adc: bcm_iproc_adc: swap primary and secondary isr handler's

On Tue, May 16, 2017 at 11:19:32AM +0530, Raveendra Padasalagi wrote:
> The third argument of devm_request_threaded_irq() is the primary
> handler. It is called in hardirq context and checks whether the
> interrupt is relevant to the device. If the primary handler returns
> IRQ_WAKE_THREAD, the secondary handler (a.k.a. handler thread) is
> scheduled to run in process context.
> 
> bcm_iproc_adc.c uses the secondary handler as the primary one
> and the other way around. So this patch fixes the same, along with
> re-naming the secondary handler and primary handler names properly.
> 
> Tested on the BCM9583XX iProc SoC based boards.
> 
> Reported-by: Pavel Roskin <plroskin@gmail.com>
> Fixes: 4324c97ecedc("iio: Add driver for Broadcom iproc-static-adc")
> Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
> ---
>  drivers/iio/adc/bcm_iproc_adc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web