Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1640855
| From | Jan Kiszka <jan.kiszka@siemens.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 5/8] gpio: exar: Fix reading of directions and values |
| Date | 2017-05-13 09:40 +0200 |
| Message-ID | <tGzOF-uC-3@gated-at.bofh.it> (permalink) |
| References | <tGzF0-rm-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
First, the logic for translating a register bit to the return code of exar_get_direction and exar_get_value were wrong. And second, there was a flip regarding the register bank in exar_get_direction. Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> --- drivers/gpio/gpio-exar.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-exar.c b/drivers/gpio/gpio-exar.c index d6ffb3d89b9c..98bd3eb1290e 100644 --- a/drivers/gpio/gpio-exar.c +++ b/drivers/gpio/gpio-exar.c @@ -68,7 +68,7 @@ static int exar_get(struct gpio_chip *chip, unsigned int reg) value = readb(exar_gpio->regs + reg); mutex_unlock(&exar_gpio->lock); - return !!value; + return value; } static int exar_get_direction(struct gpio_chip *chip, unsigned int offset) @@ -80,7 +80,7 @@ static int exar_get_direction(struct gpio_chip *chip, unsigned int offset) addr = bank ? EXAR_OFFSET_MPIOSEL_HI : EXAR_OFFSET_MPIOSEL_LO; val = exar_get(chip, addr) >> (offset % 8); - return !!val; + return val & 1; } static int exar_get_value(struct gpio_chip *chip, unsigned int offset) @@ -89,10 +89,10 @@ static int exar_get_value(struct gpio_chip *chip, unsigned int offset) unsigned int addr; int val; - addr = bank ? EXAR_OFFSET_MPIOLVL_LO : EXAR_OFFSET_MPIOLVL_HI; + addr = bank ? EXAR_OFFSET_MPIOLVL_HI : EXAR_OFFSET_MPIOLVL_LO; val = exar_get(chip, addr) >> (offset % 8); - return !!val; + return val & 1; } static void exar_set_value(struct gpio_chip *chip, unsigned int offset, -- 2.12.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/8] serial/gpio: exar: Fixes and support for IOT2000 Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-13 09:40 +0200
[PATCH 5/8] gpio: exar: Fix reading of directions and values Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-13 09:40 +0200
Re: [PATCH 5/8] gpio: exar: Fix reading of directions and values Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-13 15:40 +0200
Re: [PATCH 5/8] gpio: exar: Fix reading of directions and values Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-18 07:30 +0200
Re: [PATCH 5/8] gpio: exar: Fix reading of directions and values Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-18 12:20 +0200
Re: [PATCH 5/8] gpio: exar: Fix reading of directions and values Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-18 12:30 +0200
Re: [PATCH 5/8] gpio: exar: Fix reading of directions and values Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-18 12:30 +0200
Re: [PATCH 5/8] gpio: exar: Fix reading of directions and values Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-18 12:20 +0200
[PATCH 7/8] gpio-exar/8250-exar: Make set of exported GPIOs configurable Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-13 09:40 +0200
Re: [PATCH 7/8] gpio-exar/8250-exar: Make set of exported GPIOs configurable Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-13 16:00 +0200
[PATCH 1/8] serial: exar: Preconfigure xr17v35x MPIOs as output Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-13 09:40 +0200
Re: [PATCH 1/8] serial: exar: Preconfigure xr17v35x MPIOs as output Linus Walleij <linus.walleij@linaro.org> - 2017-05-22 17:50 +0200
[PATCH 3/8] gpio: exar: Allocate resources on behalf of the platform device Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-13 09:40 +0200
Re: [PATCH 3/8] gpio: exar: Allocate resources on behalf of the platform device Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-05-13 15:30 +0200
Re: [PATCH 3/8] gpio: exar: Allocate resources on behalf of the platform device Linus Walleij <linus.walleij@linaro.org> - 2017-05-22 17:50 +0200
[PATCH 6/8] serial: uapi: Add support for bus termination Jan Kiszka <jan.kiszka@siemens.com> - 2017-05-13 09:40 +0200
csiph-web