Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support

From	Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support
Date	2017-05-12 06:00 +0200
Message-ID	<tG9Ue-75O-9@gated-at.bofh.it> (permalink)
References	(1 earlier) <tDpVw-4CY-13@gated-at.bofh.it> <tERG2-4Yr-19@gated-at.bofh.it> <tF6F4-6g7-15@gated-at.bofh.it> <tG8lr-6ft-1@gated-at.bofh.it> <tG9AR-6YM-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On Friday 12 May 2017 09:03 AM, Michael Ellerman wrote:
> Stewart Smith <stewart@linux.vnet.ibm.com> writes:
>
>> Madhavan Srinivasan <maddy@linux.vnet.ibm.com> writes:
>>>>       * in patch 9 should opal_imc_counters_init return something other
>>>>         than OPAL_SUCCESS in the case on invalid arguments? Maybe
>>>>         OPAL_PARAMETER? (I think you fix this in a later patch anyway?)
>>> So, init call will return OPAL_PARAMETER for the unsupported
>>> domains (core and nest are supported). And if the init operation
>>> fails for any reason, it would return OPAL_HARDWARE. And this is
>>> documented.
>> (I'll comment on the skiboot one too), but I think that if the class
>> exists but init is a no-op, then OPAL_IMC_COUNTERS_INIT should return
>> OPAL_SUCCESS and just do nothing. This future proofs everything, and the
>> API is that one *must* call _INIT before start.
> Yes, 100%.
>
> That's what I described in my replies to a previous version, if it
> doesn't do that we need to fix it.
Hi mpe,

Yes, as you suggested in the opal v11 patchset, we return OPAL_SUCCESS
from _INIT for type "Nest". Have also added a prerror message logging
for debug, but can get away with it or make it as a prlog.

Maddy
>
> cheers
>

Thread

[PATCH v8 00/10] IMC Instrumentation Support Anju T Sudhakar <anju@linux.vnet.ibm.com> - 2017-05-04 16:30 +0200
  [PATCH v8 07/10] powerpc/perf: PMU functions for Core IMC and hotplugging Anju T Sudhakar <anju@linux.vnet.ibm.com> - 2017-05-04 16:30 +0200
    Re: [PATCH v8 07/10] powerpc/perf: PMU functions for Core IMC and hotplugging Stewart Smith <stewart@linux.vnet.ibm.com> - 2017-05-17 10:00 +0200
  [PATCH v8 10/10] powerpc/perf: Thread imc cpuhotplug support Anju T Sudhakar <anju@linux.vnet.ibm.com> - 2017-05-04 16:30 +0200
  [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support Anju T Sudhakar <anju@linux.vnet.ibm.com> - 2017-05-04 16:30 +0200
    Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support Daniel Axtens <dja@axtens.net> - 2017-05-08 16:20 +0200
      Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug  support Madhavan Srinivasan <maddy@linux.vnet.ibm.com> - 2017-05-09 08:20 +0200
        Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support Stewart Smith <stewart@linux.vnet.ibm.com> - 2017-05-12 04:20 +0200
          Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug support Michael Ellerman <mpe@ellerman.id.au> - 2017-05-12 05:40 +0200
            Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug  support Madhavan Srinivasan <maddy@linux.vnet.ibm.com> - 2017-05-12 06:00 +0200
          Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug  support Madhavan Srinivasan <maddy@linux.vnet.ibm.com> - 2017-05-12 05:50 +0200
      Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug  support Anju T Sudhakar <anju@linux.vnet.ibm.com> - 2017-05-09 13:00 +0200
    Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug  support Thomas Gleixner <tglx@linutronix.de> - 2017-05-10 14:20 +0200
      Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug  support Stephen Rothwell <sfr@canb.auug.org.au> - 2017-05-11 01:50 +0200
        Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug  support Thomas Gleixner <tglx@linutronix.de> - 2017-05-11 10:50 +0200
      Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug  support Madhavan Srinivasan <maddy@linux.vnet.ibm.com> - 2017-05-15 12:20 +0200
        Re: [PATCH v8 05/10] powerpc/perf: IMC pmu cpumask and cpuhotplug  support Thomas Gleixner <tglx@linutronix.de> - 2017-05-15 13:10 +0200
  [PATCH v8 06/10] powerpc/powernv: Core IMC events detection Anju T Sudhakar <anju@linux.vnet.ibm.com> - 2017-05-04 16:30 +0200
  [PATCH v8 08/10] powerpc/powernv: Thread IMC events detection Anju T Sudhakar <anju@linux.vnet.ibm.com> - 2017-05-04 16:30 +0200
  [PATCH v8 01/10] powerpc/powernv: Data structure and macros definitions for IMC Anju T Sudhakar <anju@linux.vnet.ibm.com> - 2017-05-04 16:30 +0200
  [PATCH v8 09/10] powerpc/perf: Thread IMC PMU functions Anju T Sudhakar <anju@linux.vnet.ibm.com> - 2017-05-04 16:30 +0200
  [PATCH v8 04/10] powerpc/perf: Add generic IMC pmu groupand event functions Anju T Sudhakar <anju@linux.vnet.ibm.com> - 2017-05-04 16:30 +0200
  [PATCH v8 03/10] powerpc/powernv: Detect supported IMC units and its events Anju T Sudhakar <anju@linux.vnet.ibm.com> - 2017-05-04 16:30 +0200
  [PATCH v8 02/10] powerpc/powernv: Autoload IMC device driver module Anju T Sudhakar <anju@linux.vnet.ibm.com> - 2017-05-04 16:30 +0200
    Re: [PATCH v8 02/10] powerpc/powernv: Autoload IMC device driver module Stewart Smith <stewart@linux.vnet.ibm.com> - 2017-05-11 09:50 +0200
      Re: [PATCH v8 02/10] powerpc/powernv: Autoload IMC device driver  module Madhavan Srinivasan <maddy@linux.vnet.ibm.com> - 2017-05-12 06:40 +0200

csiph-web